Skip to content

Conversation

@fselmo
Copy link
Contributor

@fselmo fselmo commented Jan 21, 2026

🗒️ Description

#2022 fixed EIP-7934 tests to account for new header fields but we did not turn these on for bal feature releases. This small change turns on all tests for the next bal pre-release, including EIP-7934 tests which can now fill for Amsterdam.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

Cute Animal Picture

Screenshot 2026-01-21 at 16 56 56

@fselmo fselmo added A-test-tests Area: tests for packages/testing C-feat Category: an improvement or new feature A-test-fill Area: execution_testing.cli.pytest_commands.plugins.filler and removed A-test-tests Area: tests for packages/testing labels Jan 22, 2026
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fselmo fselmo merged commit 3b9b018 into ethereum:forks/amsterdam Jan 22, 2026
13 checks passed
@fselmo fselmo deleted the feat/fill-7934-with-bals branch January 22, 2026 00:09
@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.16%. Comparing base (f1ba2b1) to head (0b3b3b4).
⚠️ Report is 1 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2058   +/-   ##
================================================
  Coverage            86.16%   86.16%           
================================================
  Files                  599      599           
  Lines                39527    39527           
  Branches              3780     3780           
================================================
  Hits                 34059    34059           
  Misses                4847     4847           
  Partials               621      621           
Flag Coverage Δ
unittests 86.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-fill Area: execution_testing.cli.pytest_commands.plugins.filler C-feat Category: an improvement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants