-
Notifications
You must be signed in to change notification settings - Fork 2
chore(hive): update workflow to run new bal tests #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Draft until follow-up with Felipe. |
|
Tagging @qu0b here for a review 👀 |
|
its bal-devnet-2 |
|
Yeah, I'm wanting to get a run of the existing tests of devnet-1 first (no extra EIPs)! Then update accordingly, does that seem reasonable? I'm going off the assumption that the latest BAL test release is in alignment with devnet-1. |
It's not. BAL specs in the new release are in alignment with bal-devnet-2. |
|
Ahh nice! Will update thanks. |
575ee5f to
dfcede9
Compare
|
Updated! Requires: ethereum/execution-specs#1719 to be merged to |
|
@spencer-tb looks good to me merge when ready. We can also remove the Draft status |
Description
Renames the existing
hive-devnet-0tohive-devnet-2to prepare for the latter.Adds Erigon & Nimbus. The last remaining is Ethrex (wait for response in discord).
Uses
bal-devnet-1as the client branch under test to align with the most recent BAL test releasebal@v3.0.1. Confirm with @fselmo. This will be updated tobal-devnet-2once:bal-devnet-2branch with the EIPs.Confirm with @fselmo if
EELS_BUILD_ARG_BRANCH: forks/amsterdamis the correct EELS branch for running BAL tests in hive.