Skip to content

Add installation of executables #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2025
Merged

Add installation of executables #59

merged 3 commits into from
Oct 16, 2025

Conversation

@daipom
Copy link
Contributor

@daipom daipom commented Oct 15, 2025 •
edited by kou
Loading

Fixes #55

@daipom daipom mentioned this pull request Oct 15, 2025
Closed
@daipom daipom force-pushed the add-installation-of-exeutables branch from 437fd33 to af43ad6 Compare October 15, 2025 09:20
daipom
daipom commented Oct 15, 2025
View reviewed changes
kou
kou reviewed Oct 16, 2025
View reviewed changes
@daipom daipom force-pushed the add-installation-of-exeutables branch from af43ad6 to 3e0df06 Compare October 16, 2025 01:17
@daipom daipom marked this pull request as ready for review October 16, 2025 01:23
kou
kou reviewed Oct 16, 2025
View reviewed changes
@daipom @kou
Add installation of executables
bcd7aef 
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
@daipom daipom force-pushed the add-installation-of-exeutables branch from 3e0df06 to bcd7aef Compare October 16, 2025 02:24
@packit-as-a-service
Copy link

packit-as-a-service bot commented Oct 16, 2025

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/enactic-openarm_can-59
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

1 similar comment
@packit-as-a-service
Copy link

packit-as-a-service bot commented Oct 16, 2025

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/enactic-openarm_can-59
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@daipom
Copy link
Contributor Author

daipom commented Oct 16, 2025

I have merged #58 (@bkmgit's fix) to resolve the CI failures.
As a result, this PR will also cover #58.
Could you please check this? @kou @bkmgit
Please let me know if these PRs shouldn’t have been combined.

kou
kou reviewed Oct 16, 2025
View reviewed changes
@daipom @kou
Apply CMake change to .spec
81d3fa0 
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
@daipom daipom force-pushed the add-installation-of-exeutables branch from b49c853 to 81d3fa0 Compare October 16, 2025 02:56
@bkmgit
Copy link
Contributor

bkmgit commented Oct 16, 2025

@daipom It is fine for me to merge them.

@kou kou merged commit 010ea25 into enactic:main Oct 16, 2025
16 checks passed
@daipom daipom deleted the add-installation-of-exeutables branch October 16, 2025 06:25
This was referenced Oct 16, 2025
Closed
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou left review comments

+1 more reviewer

@bkmgit bkmgit bkmgit left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add openarm_can-utils rpm subpackage

3 participants

@daipom @bkmgit @kou