packages: add utils rpm subpackage #58
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
kou
reviewed
Oct 12, 2025
| # https://packit.dev/docs/configuration/ | ||
|
|
||
| specfile_path: packages/fedora/openarm-can.spec | ||
| specfile_path: packages/fedora/openarm_can.spec |
Contributor
Author
There was a problem hiding this comment.
The package name is openarm_can. Can get it changed if needed/preferred.
Contributor
There was a problem hiding this comment.
Could you use openarm-can not openarm_can to align with Debian package, .pc name and so on?
Contributor
Author
There was a problem hiding this comment.
Ok, will rename the package.
Comment on lines
+57
to
+61
| mkdir -p %{buildroot}%{_libexecdir}/openarm_can | ||
| install -pm 0751 setup/configure_socketcan.sh \ | ||
| %{buildroot}%{_libexecdir}/openarm_can/configure_socketcan.sh | ||
| install -pm 0751 setup/set_zero.sh \ | ||
| %{buildroot}%{_libexecdir}/openarm_can/set_zero.sh |
Contributor
There was a problem hiding this comment.
We should do this by CMake to avoid duplicated codes in debian/ and .spec.
Cc: @daipom
Contributor
|
@bkmgit Can we close this now? |
Contributor
Author
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #55