Skip to content

[ML] JIndex: Restore finalize job action #35856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

davidkyle
Copy link
Member

Feature branch PR for the master feature branch

TransportFinalizeJobExecutionAction has already been restored to 6.x and its use simplifies the code in AutoDetectResultsProcessor.

Plus some small non-functional changes to match the 6.x branch

@davidkyle davidkyle added >feature :ml Machine learning labels Nov 23, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

Christoph Büscher and others added 2 commits November 23, 2018 14:29
Adds a verification mode for read-only repositories. It also makes the extra bucket check on
repository creation obsolete, which fixes elastic#35703.
@davidkyle
Copy link
Member Author

run gradle build tests

@davidkyle
Copy link
Member Author

test this please

Copy link
Contributor

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This PR was backported to 6.x, so the extra BWC conditions are not needed anymore
@davidkyle
Copy link
Member Author

run gradle build tests 2

matriv and others added 17 commits November 23, 2018 22:19
NULLIF returns null if the 2 expressions are equal or the
expr1 otherwise.

Closes: elastic#35818
Code that operates on-top of the engine requires all readers returned to be
unwrapped into ElasticsearchDirectoryReader. The special reader
the FrozenEngine uses wasn't wrapped.
…5837)

Acquiring a searcher is unnecessary to determine if a refresh is
necessary since read-only engines never refresh.

Closes elastic#35785
* Disable snapshot repo verification temporarily because it runs into HTTP-500 in 6.6.0-SNAPSHOT
* Relates elastic#35874
* Introduced "client.id" parameter for REST requests
* Bug that made the Verifier run twice, fixed in the Analyzer
* Single node IT and unit testing
…tic#35535)

The `wait_for_metadata_version` parameter will instruct the cluster state
api to only return a cluster state until the metadata's version is equal or
greater than the version specified in `wait_for_metadata_version`. If  
the specified `wait_for_timeout` has expired then a timed out response 
is returned. (a response with no cluster state and wait for timed out flag set to true)
In  the case metadata's version is equal or higher than  `wait_for_metadata_version`
then the api will immediately return.

This feature is useful to avoid external components from constantly
polling the cluster state to whether somethings have changed in the
cluster state's metadata.
This commits adds support for the Get Roles API to the HLRC

Relates: elastic#29827
This commit simplifies  the throttling logic in InitialSearchPhase and removes some asserts from it. Also, a few formatting changes are applied to its code and surrounding classes.
This test fails on CI because of an inappropriate assertion, which is
I think a leftover and has no real value.
edsavage and others added 26 commits November 26, 2018 16:15
This commit removes the redundant (and incorrect) JAVACLASS
and JAVAFILE grok patterns. This helps to keep parity with 
Logstash's patterns. 

See also: logstash-plugins/logstash-patterns-core#237
 
closes elastic#35699
Add GREATEST(expr1, expr2, ... exprN) and LEAST(expr1, expr2, exprN)
functions which are in the family of CONDITIONAL functions.

Implementation follows PostgreSQL behaviour, so the functions return
`NULL` when all of their arguments evaluate to `NULL`.

Renamed `CoalescePipe` and `CoalesceProcessor` to `ConditionalPipe` and
`ConditionalProcessor` respectively, to be able to reuse them for
`Greatest` and `Least` evaluations. To achieve that `ConditionalOperation`
has been added to differentiate between the functionalities at execution
time.

Closes: elastic#35878
This commit adds the support for exists query in the sorted execution mode
of the `composite` aggregation. We'll execute the aggregation from the sorted
points and use early termination if the main query is an `exists` query over the
first source of the `composite` aggregation.
Improves handling of malformed geo_points when `ignore_malformed` is
set to true

Closes elastic#35419
Fields should be declared at the top of the class, before any method declarations, constructors, initializers or inner classes.
Adds HLRC documentation for the Explain Lifecycle API.
This removes the option to run a cluster without enforcing the
cluster-wide shard limit, making strict enforcement the default and only
behavior.  The limit can still be adjusted as desired using the cluster
settings API.
This commit adds back bundling of all deps of the sql jdbc jar. This was
lost in a refactoring of how the shadow plugin is handled for the entire
elasticsearch project.
Watcher still exposes some dates as joda DateTime objects. This commit
adds back joda to the painless whitelist so they can still be accessed.

closes elastic#35913
Update PutUserRequest to support password_hash (see: elastic#35242)

This also updates the documentation to bring it in line with our more
recent approach to HLRC docs.
When assertions are enabled, a Put User action that have no effect (a
noop update) would trigger an assertion failure and shutdown the node.

This change accepts "noop" as an update result, and adds more
diagnostics to the assertion failure message.
This generates a synthesized "id" for each incoming request that is
included in the audit logs (file only).
This id can be used to correlate events for the same request (e.g.
authentication success with access granted).

This request.id is specific to the audit logs and is not used for any
other purpose

The request.id is consistent across nodes if a single request requires
execution on multiple nodes (e.g. search acros multiple shards).
This commit adds a test for handling correctly all they possible 
`SamlPrepareAuthenticationRequest` parameter combinations that 
we might get from Kibana or a custom web application talking to the
SAML APIs. 
We can match the correct SAML realm based either on the realm name
or the ACS URL. If both are included in the request then both need to 
match the realm configuration.
This change also adds documentation for the Put Auto Follow Pattern API.

Relates to elastic#33824
This commit adds documentation for authorization_realms
setting for the Kerberos realm and also corrects a typo in
existing documentation.

Co-authored-by: @A-Hall
…nator,

it has nothing to do with the hlrc support for put auto follow pattern api,
this test was added for.

Relates to elastic#35480
Simplify AutoDetectResultsProcessor by using the restored action
@davidkyle
Copy link
Member Author

Closing due to a git snafu, will reopen the change in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>feature :ml Machine learning
Projects
None yet
Development

Successfully merging this pull request may close these issues.