Skip to content

[ILM] TEST: skip checking _ilm/explain response b/c flaky timing #35562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 15, 2018
Merged

[ILM] TEST: skip checking _ilm/explain response b/c flaky timing #35562

merged 3 commits into from
Nov 15, 2018

Conversation

talevy
Copy link
Contributor

@talevy talevy commented Nov 14, 2018

Closes #35515.

@talevy talevy added >test Issues or PRs that are addressing/adding tests :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Nov 14, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@gwbrown
Copy link
Contributor

gwbrown commented Nov 14, 2018 •
edited
Loading

While I understand the difficulty in this particular instance, I think it would be good to see if there's any adjustments we can make to the doc test framework to make this work - they caught an issue in these docs that I accidentally introduced in #35524 just yesterday.

dakrone
dakrone approved these changes Nov 14, 2018
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it'd be great if we could solve this with the docs testing infrastructure, for now this is the best option so we don't see more failures coming from these docs

@talevy talevy merged commit 95a09ab into elastic:master Nov 15, 2018
@talevy talevy deleted the fix-explain-doc branch November 15, 2018 00:45
talevy added a commit that referenced this pull request Nov 15, 2018
@talevy
[ILM] TEST: skip checking _ilm/explain response b/c flaky timing (#35562
3bc6dc5 
)

The docs are not resilient to timing issues where the ILM metadata is not set on newly 
created indices, so we shouldn't be so strict on the returned response
@danielmitterdorfer danielmitterdorfer mentioned this pull request Nov 22, 2018
Closed
talevy added a commit to talevy/elasticsearch that referenced this pull request Nov 22, 2018
@talevy
[TEST] ILM skip checking _ilm/explain response
3a4bf2f 
relates elastic#35562

Closes elastic#35824.
@talevy talevy mentioned this pull request Nov 22, 2018
Merged
talevy added a commit that referenced this pull request Nov 26, 2018
@talevy
[TEST] ILM skip checking _ilm/explain response (#35830)
a0f8a22 
relates #35562

Closes #35824.
talevy added a commit that referenced this pull request Nov 26, 2018
@talevy
[TEST] ILM skip checking _ilm/explain response (#35830)
016e815 
relates #35562

Closes #35824.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakrone dakrone dakrone approved these changes

@colings86 colings86 Awaiting requested review from colings86

@gwbrown gwbrown Awaiting requested review from gwbrown

Assignees
No one assigned
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@talevy @elasticmachine @gwbrown @dakrone