Skip to content

Add read-only repository verification #35731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 23, 2018

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Nov 20, 2018

Adds a verification mode for read-only repositories. It also makes the extra bucket check on repository creation obsolete, which fixes #35703.

@ywelsch ywelsch added >enhancement :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v7.0.0 v6.6.0 labels Nov 20, 2018
@ywelsch ywelsch requested review from tlrx and jasontedor November 20, 2018 11:01
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update the docs to reflect the changes in the permissions that the repository-s3 plugin now requires?

@ywelsch
Copy link
Contributor Author

ywelsch commented Nov 20, 2018

@DaveCTurner with this PR we do not require any new permissions. Instead, it removes the extra requirement introduced by #34123

@ywelsch ywelsch merged commit 2970abf into elastic:master Nov 23, 2018
ywelsch added a commit that referenced this pull request Nov 23, 2018
Adds a verification mode for read-only repositories. It also makes the extra bucket check on
repository creation obsolete, which fixes #35703.
ywelsch added a commit that referenced this pull request Nov 23, 2018
This PR was backported to 6.x, so the extra BWC conditions are not needed anymore
mkleen added a commit to crate/crate that referenced this pull request May 26, 2020
mkleen added a commit to crate/crate that referenced this pull request May 26, 2020
mkleen added a commit to crate/crate that referenced this pull request May 26, 2020
mkleen added a commit to crate/crate that referenced this pull request May 26, 2020
mkleen added a commit to crate/crate that referenced this pull request May 27, 2020
mergify bot pushed a commit to crate/crate that referenced this pull request May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 repository rejects access with documented s3:prefix condition
5 participants