Always return false from refreshNeeded on ReadOnlyEngine
#35837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acquiring a searcher is unnecessary to determin if a refresh is necessary since read-only engines never refresh. Closes elastic#35785
s1monw
added
>enhancement
v7.0.0
:Distributed Indexing/Engine
|
Pinging @elastic/es-distributed |
jpountz
approved these changes
Nov 23, 2018
|
@elasticmachine test this please |
bleskes
approved these changes
Nov 23, 2018
s1monw
added a commit
that referenced
this pull request
Nov 24, 2018
Acquiring a searcher is unnecessary to determine if a refresh is necessary since read-only engines never refresh. Closes #35785
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acquiring a searcher is unnecessary to determine if a refresh is
necessary since read-only engines never refresh.
Closes #35785