Skip to content

Conversation

@0nko
Copy link
Member

@0nko 0nko commented Nov 3, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1211819634741598?focus=true

Description

This PR removes the newToolbarFeature feature flag and all the associated logic.

Steps to test this PR

Top omnibar

  • Set the omnibar position to TOP
  • Go to the tab switcher
  • Verify all the buttons work as expected
  • Verify the menu items work as expected
  • Verify the selection mode works (tap on Select tabs in the menu) as expected
  • Verify the tab scrolling works as expected (create many tabs in the developer mode)

Bottom omnibar

  • Set the omnibar position to BOTTOM
  • Go to the tab switcher
  • Verify all the buttons work as expected
  • Verify the menu items work as expected
  • Verify the selection mode works (tap on Select tabs in the menu) as expected
  • Verify the tab scrolling works as expected (create many tabs in the developer mode)

@0nko 0nko mentioned this pull request Nov 3, 2025
20 tasks
@0nko 0nko changed the title Clean up the menu items Split Omnibar: Remove old feature flag Nov 3, 2025
@0nko 0nko marked this pull request as ready for review November 3, 2025 10:42
@0nko 0nko requested a review from LukasPaczos November 3, 2025 10:52
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-ff-cleanup branch from c666485 to 7da87ad Compare November 3, 2025 18:10
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-address-bar branch from 539390e to 697f6fb Compare November 3, 2025 18:10
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-ff-cleanup branch 2 times, most recently from d945faa to 0393ac7 Compare November 3, 2025 18:36
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-address-bar branch from 065ac0e to 7b19df7 Compare November 3, 2025 18:36
@0nko 0nko requested review from malmstein and removed request for LukasPaczos November 3, 2025 18:45
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-ff-cleanup branch from 0393ac7 to d4e3ddf Compare November 3, 2025 19:04
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-address-bar branch from e25a604 to 643feee Compare November 4, 2025 08:07
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-ff-cleanup branch from d4e3ddf to 44d7e65 Compare November 4, 2025 08:07
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-ff-cleanup branch from 44d7e65 to b574170 Compare November 4, 2025 16:35
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-address-bar branch from 7ebd273 to b136ce0 Compare November 4, 2025 16:35
@0nko 0nko mentioned this pull request Nov 4, 2025
15 tasks
Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malmstein malmstein self-assigned this Nov 4, 2025
Base automatically changed from feature/ondrej/split-omnibar-address-bar to develop November 5, 2025 10:43
@0nko 0nko merged commit 5a5234f into develop Nov 5, 2025
11 of 15 checks passed
@0nko 0nko deleted the feature/ondrej/split-omnibar-ff-cleanup branch November 5, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants