Skip to content

Conversation

@0nko
Copy link
Member

@0nko 0nko commented Oct 24, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211565479656356?focus=true

Description

This PR updates the Appearance settings screen with the new pictograms and includes the split omnibar option.

Steps to test this PR

Figma design for reference: Figma

Old settings

  • Go to Settings -> Appearance
  • Verify the old omnibar position is displayed

New settings

  • Enable splitOmnibar in the feature flags
  • Go to Settings -> Appearance
  • Verify the new omnibar type pictograms are displayed
  • Verify the correct omnibar type is selected
  • Try changing the current type for each option
  • Verify the new type is visually selected
  • Leave the Appearance settings and come back
  • Verify the previous selection is restored

Dark mode

  • Change the theme to dark mode
  • Verify new dark pictograms are used
  • Select each option and verify the dark-mode selection options are show

Omnibar type fallback when feature disabled

  • Go to Settings -> Appearance
  • Change the omnibar type to Split
  • Go to the feature flag settings
  • Disable the useUnifiedOmnibar feature
  • Restart the app
  • Go to Settings -> Appearance
  • Verify the omnibar position is set to Top

UI changes

Before After
image image

@0nko 0nko changed the title Add new drawable and string resources Split Omnibar: Oct 24, 2025
@0nko 0nko changed the title Split Omnibar: Split Omnibar: Settings screen Oct 24, 2025
@0nko 0nko requested a review from malmstein October 24, 2025 17:23
@0nko 0nko marked this pull request as ready for review October 24, 2025 17:23
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-data-type branch from 86457ba to e376ab4 Compare October 27, 2025 11:26
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-settings branch from 145aefd to 449aab5 Compare October 27, 2025 11:26
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-data-type branch from e376ab4 to be9ddaf Compare October 27, 2025 17:17
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-settings branch 2 times, most recently from ee462f6 to c5dba8f Compare October 27, 2025 17:41
@0nko 0nko requested review from LukasPaczos and removed request for malmstein October 27, 2025 17:42
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-data-type branch from 044f781 to 31606a2 Compare October 27, 2025 17:49
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-settings branch 2 times, most recently from 7a5baef to e0f50df Compare October 27, 2025 20:18
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-data-type branch from 2d917a4 to 37c919c Compare October 28, 2025 15:49
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-settings branch 2 times, most recently from 95578fe to 492e28e Compare October 28, 2025 15:54
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-data-type branch from 37c919c to 9effa5e Compare October 28, 2025 15:54
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-settings branch from 492e28e to 7aa6af8 Compare October 28, 2025 20:42
@0nko 0nko mentioned this pull request Oct 29, 2025
14 tasks
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-settings branch from 7aa6af8 to a9e1f85 Compare October 30, 2025 09:45
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-data-type branch from 83ce28b to 1965900 Compare October 30, 2025 09:45
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-settings branch from a9e1f85 to 3c2291d Compare October 30, 2025 11:00
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-data-type branch from cc81f57 to cff6c4f Compare October 30, 2025 18:41
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-settings branch from 3c2291d to 9fa71f9 Compare October 30, 2025 18:41
Base automatically changed from feature/ondrej/split-omnibar-data-type to develop October 31, 2025 09:33
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-settings branch 2 times, most recently from 6ca751e to 5dcfdfe Compare October 31, 2025 12:16
@0nko 0nko requested a review from LukasPaczos October 31, 2025 12:20
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-settings branch from 5dcfdfe to 7e900b3 Compare October 31, 2025 21:02
@0nko 0nko mentioned this pull request Oct 31, 2025
7 tasks
Copy link
Contributor

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…Model.kt

Co-authored-by: Łukasz Paczos <lpaczos@duckduckgo.com>
@0nko 0nko merged commit d985d52 into develop Nov 3, 2025
7 checks passed
@0nko 0nko deleted the feature/ondrej/split-omnibar-settings branch November 3, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants