Split Omnibar: Omnibar layout refactoring

[0nko]

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1211565479656354

Description

This PR refactors the OmnibarLayout and SingleOmnibarLayout. OmnibarLayout was renamed to LegacyOmnibarLayout and a new OmnibarLayout is a unified, merged version of OmnibarLayout and SingleOmnibarLayout.

Thew new omnibar is guarded by a useUnifiedOmnibarLayout feature flag. To make that work, an OminbarView interface needed to be extracted, which is now used within the Omnibar class. Depending on the flag value, either the old LegacyOmnibarLayout or the new OmnibarLayout is used. The feature flag is enabled by default.

Also, some of the interfaces from OmnibarLayout had to be extracted (StateChange, Decoration) to avoid duplication.

Steps to test this PR

FF enabled

• Verify that onboarding highlighting works
• Verify all buttons work
• Verify tab swiping works
• Verify tracker animations work
• Verify the cookies animations work
• Verify that omnibar hiding on scroll works

FF disabled

• Disable the useUnifiedOmnibarLayout FF in the internal settings
• Verify that onboarding highlighting works
• Verify all buttons work
• Verify tab swiping works
• Verify tracker animations work
• Verify the cookies animations work
• Verify that omnibar hiding on scroll works

[0nko]

• Split Omnibar: Ship review changes #7083
• Split Omnibar: Existing functionality integration #7062
• Split Omnibar: Tab switcher bottom bar #7056
• Split Omnibar: Remove old feature flag #7045
• Split Omnibar: Address bar integration #7042
• Split Omnibar: Bottom navigation #7032
• Split Omnibar: Settings screen #7002
• Split Omnibar: Data type & storage update #6991
• Split Omnibar: Omnibar layout refactoring #6983 👈 (View in Graphite)
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

[LukasPaczos]

The changes generally look good and work as expected. However, the new UnifiedOmnibarLayout.kt file is difficult to review in its current form. If this is intended to be the long-term layout location, it also loses the git history from all iterations of OmnibarLayout.

Instead of creating a new UnifiedOmnibarLayout.kt file, I suggest:

1. Copy the existing OmnibarLayout into a new file (LegacyOmnibarLayout?).
2. Rename the existing OmnibarLayout to UnifiedOmnibarLayout.
3. Apply the necessary changes there.
4. When we're confident in the changes, we'll remove the Legacy* copies.

The same approach can be used for the XML files, view model, and view model tests. This should be straightforward to copy-paste and would preserve git history and make the diff easier to review for the code that will remain long-term.

[0nko]

Thanks @LukasPaczos! I've refactored the code as you suggested. In fact, while working on this I realized that a separate ViewModel is not needed as there is no new functionality and a single OmnibarLayoutViewModel can be used by both the old and new layout. Hence, I also removed the extra unit test copy and cut the amount of changes to half 🎉.

[LukasPaczos]

Looks great!