Skip to content

Commit 8e18447

Browse files
authored
resolve stack overflow when showing/hiding omnibar (#7023)
Task/Issue URL: https://app.asana.com/1/137249556945/project/414730916066338/task/1211782850017596?focus=true ### Description Resolve a regression where function invocation changed from an extension to recursion during a refactor in #6983. ### Steps to test this PR - [x] Open the app. - [x] Search and go to videos. - [x] Start a video. - [x] Open full screen. - [x] Close full screen.
1 parent eab5c06 commit 8e18447

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

app/src/main/java/com/duckduckgo/app/browser/omnibar/LegacyOmnibarLayout.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -999,11 +999,11 @@ open class LegacyOmnibarLayout @JvmOverloads constructor(
999999
}
10001000

10011001
override fun show() {
1002-
show()
1002+
visibility = View.VISIBLE
10031003
}
10041004

10051005
override fun gone() {
1006-
gone()
1006+
visibility = View.GONE
10071007
}
10081008
}
10091009

app/src/main/java/com/duckduckgo/app/browser/omnibar/OmnibarLayout.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1175,10 +1175,10 @@ class OmnibarLayout @JvmOverloads constructor(
11751175
}
11761176

11771177
override fun show() {
1178-
show()
1178+
visibility = View.VISIBLE
11791179
}
11801180

11811181
override fun gone() {
1182-
gone()
1182+
visibility = View.GONE
11831183
}
11841184
}

0 commit comments

Comments
 (0)