Skip to content

Split Omnibar: Ship review changes #7083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 11, 2025
Merged

Split Omnibar: Ship review changes #7083

merged 8 commits into from
Nov 11, 2025
+117 −387

Conversation

@0nko
Copy link
Member

@0nko 0nko commented Nov 7, 2025 •
edited
Loading

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1211859724075437?focus=true

Description

  • Fixes the thicker shadows in the tab manager
  • Prevents opening of the keyboard on NTP in most cases
  • Reduced bottom navigation height by 8dp

Steps to test this PR

Feature 1

  • [ ]
  • [ ]

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

This was referenced Nov 7, 2025
Merged
Merged
Merged
Merged
Merged
@0nko 0nko changed the title Apply the touch ripple only to the pictograms Split Omnibar: Ship review changes Nov 7, 2025
This was referenced Nov 7, 2025
Merged
Merged
@0nko Graphite App
Copy link
Member Author

0nko commented Nov 7, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@0nko 0nko mentioned this pull request Nov 7, 2025
Merged
15 tasks
@0nko 0nko requested a review from malmstein November 7, 2025 14:41
@0nko 0nko marked this pull request as ready for review November 7, 2025 14:42
@0nko 0nko requested a review from mikescamell as a code owner November 7, 2025 14:42
@0nko 0nko removed the request for review from mikescamell November 7, 2025 14:45
malmstein
malmstein approved these changes Nov 7, 2025
View reviewed changes
Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving this, wait for SR feedback before merging

@0nko 0nko force-pushed the feature/ondrej/split-omnibar-ship-review branch from 9d3c5ce to a747639 Compare November 7, 2025 22:03
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-integration branch from d1af959 to 870cbdd Compare November 7, 2025 22:03
@malmstein malmstein self-assigned this Nov 10, 2025
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-integration branch from 870cbdd to c06df7e Compare November 11, 2025 03:33
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-ship-review branch from a747639 to 2223c42 Compare November 11, 2025 03:33
Base automatically changed from feature/ondrej/split-omnibar-integration to develop November 11, 2025 04:28
@0nko 0nko force-pushed the feature/ondrej/split-omnibar-ship-review branch from 2223c42 to 43a0ef7 Compare November 11, 2025 04:30
@0nko 0nko merged commit 57147f6 into develop Nov 11, 2025
6 of 7 checks passed
@0nko 0nko deleted the feature/ondrej/split-omnibar-ship-review branch November 11, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malmstein malmstein malmstein approved these changes

Assignees

@malmstein malmstein

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0nko @malmstein