Skip to content

Commit b136ce0

Browse files
committed
Fix the bottom outline when split omnibar selected
1 parent dc0673a commit b136ce0

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1631,7 +1631,7 @@ class BrowserTabFragment :
16311631
.flowWithLifecycle(lifecycle, Lifecycle.State.RESUMED)
16321632
.collectLatest { hasFavorites ->
16331633
binding.includeNewBrowserTab.topNtpOutlineStroke.isVisible = hasFavorites
1634-
binding.includeNewBrowserTab.bottomNtpOutlineStroke.isVisible = hasFavorites
1634+
binding.includeNewBrowserTab.bottomNtpOutlineStroke.isVisible = hasFavorites && !omnibarFeatureRepository.isSplitOmnibarEnabled
16351635
}
16361636
}
16371637

app/src/main/java/com/duckduckgo/app/browser/omnibar/Omnibar.kt

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,11 +184,16 @@ class Omnibar(
184184
binding.rootView.removeView(binding.singleOmnibarLayoutBottom)
185185

186186
return when (omnibarType) {
187-
OmnibarType.SINGLE_TOP, OmnibarType.SPLIT -> {
187+
OmnibarType.SINGLE_TOP -> {
188188
binding.rootView.removeView(binding.omnibarLayoutBottom)
189189
binding.omnibarLayoutTop
190190
}
191-
191+
OmnibarType.SPLIT -> {
192+
binding.rootView.removeView(binding.omnibarLayoutBottom)
193+
binding.bottomBrowserOutlineStroke.gone()
194+
binding.includeNewBrowserTab.bottomNtpOutlineStroke.gone()
195+
binding.omnibarLayoutTop
196+
}
192197
OmnibarType.SINGLE_BOTTOM -> {
193198
binding.rootView.removeView(binding.omnibarLayoutTop)
194199
adjustCoordinatorLayoutBehaviorForBottomOmnibar()

0 commit comments

Comments
 (0)