FI from runtime master to dev/infrastructure as of 06/16 #37982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve the robustness and idempotence of compile-serp by backing up all MSIL assemblies that are compiled / referenced. Use those backups during compilations. * Add `--composite-scenario` switch which currently supports two modes: each assembly is compiled separately, and another where the shared framework, Asp.Net, and Serp core each get a composite image. * Added new `Crossgen2RunnerOptions` config class we can pass per-compile settings instead of relying on the process-wide `BuildOptions` object. This is needed to allow a single parallel batch of compilations where some are composite images and some are not.
…t#37562) * Update dependencies from https://github.com/mono/linker build 20200606.1 Microsoft.NET.ILLink.Tasks From Version 5.0.0-preview.3.20305.2 -> To Version 5.0.0-preview.3.20306.1 * Update dependencies from https://github.com/microsoft/vstest build 20200608-10 Microsoft.NET.Test.Sdk From Version 16.7.0-preview-20200605-01 -> To Version 16.7.0-preview-20200608-10 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Setting LangVersion in a .targets file makes it hard to override LangVersion in individual projects. Instead, move the default project setting back to the .props file and condition VB based on $(MSBuildProjectExtension), which is available in the .props file. ILCompiler.Reflection.ReadyToRun needs to set LangVersion to 7.3 so it doesn't break ILSpy. Fix dotnet#37498
* allow MemoryMeppedFile to work on character device * feedback from review * feedback from review * feedback from review * roll-back write only access * feedback from review * fix windows * avoid exception reordering * feedback from review Co-authored-by: Tomas Weinfurt <furt@Shining.local>
* don't use process var in async readers * Add comment
Update "LICENSE.txt" so that it's recognized as MIT
…eption when starting threads/waiting on monitors. (dotnet#37604) <!-- Thank you for your Pull Request! If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed. Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number --> Co-authored-by: vargaz <vargaz@users.noreply.github.com>
* Enable for arm/arm64. * Add more test cases specific to SIMD* handling. * Support !compDoOldStructRetyping for arm/arm64. * Review feedback. * Return `JitDoOldStructRetyping`. and disable failung tests with old retyping. * a small workaround for default arm64 behaviour.
…ce types (dotnet#37593) * Annotate System.Net.WebSockets.WebSocketProtocol for nullable reference types This also helped find that the annotation of WebSocketReceiveResult(..., string closeDescription) was wrong in the ref (it was correct in the src), so I fixed that. * Address PR feedback and suppress netcoreapp2.1 warnings
Maintains nullable annotation on RawData.
* Respect Process.SynchronizingObject in Process events * Address PR feedback
* Ensure the right SIMD size is used for the AsVector256 AVX code * Don't create GT_SIMD nodes if the baseline ISAs are not supported.
* Sorted the build scripts' help alphabetically, and made the subset error message softer and without metrics. * Added simple examples to the scripts' helps. * Moved short flags to the flag column and rephrased a bit. * Removed remains of old code. * Added more examples and rephrased some things for better clarity. * Added gcc example to build.sh. * Corrected definition of the Checked configuration. * Added --clangx to build.sh
…37626) * Revert "Update "LICENSE.txt" so that it's recognized as MIT" * Add LICENSE.TXT to global build Co-authored-by: Santiago Fernandez Madero <safern@microsoft.com>
…tnet#37621) * Accept NativeCallableInternalAttribute to support legacy scenario * Feedback
* Move current ASN src and tests into new tree with no modifications AsnReader partials are named AsnDecoder to better match the final name for the core logic they contain. * Make System.Formats.Asn1 package * Apply changes from API review Some additional tests were written to increase code coverage after the changes * Move AsnReader consumers to public API
* Exclude MemberNotNull from various tools * Use [MemberNotNull] to reduce use of `= null!;`
Some of these are handled as linker intrinsics, so they'll actually keep less than what the annotation declares. The annotation mostly serves to suppress warnings when linker analyzes the body of the method itself.
Some of our full facades are missing `<Nullable>enable</Nullable>`. I don't think the lack of these causes any issues, but having them makes it easy to confirm what ref assemblies remain to be annotated.
… in libraries (dotnet#37600) * Create Microsoft.NetCore.App.Ref Binplace reference assemblies into a Microsoft.NetCore.App.Ref folder and also copy data files like the RuntimeList.xml and the PlatformManifest.txt there. Rename the runtime pack to microsoft.netcore.app.runtime.$(RID) Fixing a restore issue in the wasm builder (restore and build should not happen in the same msbuild invocation).
dotnet#37488) * Annotate Microsoft.Extensions.DependencyInjection.Abstractions for nullable reference types Contributes to dotnet#2339
* Add JIT stress mode testing using libraries tests There are three separate pipelines, with different sets of JIT stress modes enabled for each: - libraries-jitstress.yml - libraries-jitstress2-jitstressregs.yml - libraries-jitstressregs.yml The live built Release libraries are used with a Checked CoreCLR. The non-stress configuration is tested during normal PR testing. The libraries `sendtohelix.proj` file is changed to take an optional list of CoreCLR stress scenarios to run. If given, a set of environment setting scripts is created and added to the Helix correlation payload. Then, an auxiliary `sendtohelixhelp.proj` file is invoked for each scenario (or just the default, empty scenario) to create and run the Helix tasks. * Remove remnants of old corefx-on-coreclr test run infrastructure * Rename corefx-*.yml to libraries-*.yml * Disable tests ``` src/libraries/System.Numerics.Vectors/tests/Matrix3x2Tests.cs dotnet#36587 Matrix3x2CreateRotationCenterTest() dotnet#36587 Matrix3x2CreateScaleCenterTest1() dotnet#36587 Matrix3x2CreateScaleCenterTest3() src/libraries/System.Numerics.Vectors/tests/Matrix4x4Tests.cs dotnet#36586 Matrix4x4CreateFromAxisAngleTest() ``` * Fix run-test-job.yml * Fix BuildAllConfigurations case
trylek
requested review from
akoeplinger,
alexischr,
BrzVlad,
CoffeeFlux,
EgorBo,
imhameed,
jozkee,
lambdageek,
lateralusX,
layomia,
marek-safar,
SamMonoRT,
steveharter,
steveisok and
vargaz
as code owners
|
Tagging subscribers to this area: @ViktorHofer |
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
jashook
approved these changes
Jun 18, 2020
|
Merging with one failure tracked under #37946. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have prepared another FI to dev/infrastructure as I'm starting
to lab test the runtime test migration change and I've noticed
a bit of churn in master regarding the test set.
Thanks
Tomas