allow access to crypto props from RemoteCertificateValidationCallback #37580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wfurt
added
enhancement
|
Tagging subscribers to this area: @dotnet/ncl |
stephentoub
reviewed
Jun 8, 2020
| @@ -863,6 +863,17 @@ private void ThrowIfExceptionalOrNotAuthenticated() | |||
| } | |||
| } | |||
|
|
|||
| [MethodImpl(MethodImplOptions.AggressiveInlining)] | |||
There was a problem hiding this comment.
Are the call sites very hot paths? Wondering if it's really beneficial to force inline it like this.
There was a problem hiding this comment.
I can try to measure it. For now, I just followed pattern from other helper methods.
Generally I would not expect them on hot path. The properties would either never be used or used once for logging after handshake is completed.
stephentoub
approved these changes
Jun 8, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The information is already ready. It is set by ProcessHandshakeSuccess() in CompleteHandshake() prior to calling VerifyRemoteCertificate(). The problem is that _handshakeCompleted is not yet set to true so attempt to access the properties from callback will throw.
I did not want to touch _handshakeCompleted as that would change external behavior and set IsAutneticated prematurely. Instead, I added new helper function to allow access also if ConnectionInfo is available e.g. we progressed far enough in the handshake.
fixes #919