Create Microsoft.NetCore.App.Ref targeting pack for NetCoreAppCurrent in libraries #37600
Conversation
Binplace reference assemblies into a Microsoft.NetCore.App.Ref folder and also copy data files like the RuntimeList.xml and the PlatformManifest.txt there. Rename the runtime pack to microsoft.netcore.app.runtime.$(RID) Fixing a restore issue in the wasm builder (restore and build should not happen in the same msbuild invocation).
ViktorHofer
requested review from
EgorBo,
marek-safar,
steveisok and
vargaz
as code owners
|
Tagging subscribers to this area: @ViktorHofer |
ViktorHofer
changed the title
| <MicrosoftNetCoreAppRefPackRefDir>$([MSBuild]::NormalizeDirectory('$(MicrosoftNetCoreAppRefPackDir)', 'ref'))</MicrosoftNetCoreAppRefPackRefDir> | ||
| <MicrosoftNetCoreAppRefPackDataDir>$([MSBuild]::NormalizeDirectory('$(MicrosoftNetCoreAppRefPackDir)', 'data'))</MicrosoftNetCoreAppRefPackDataDir> | ||
|
|
||
| <MicrosoftNetCoreAppRuntimePackDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsBinDir)', 'microsoft.netcore.app.runtime.$(PackageRID)', '$(Configuration)'))</MicrosoftNetCoreAppRuntimePackDir> |
There was a problem hiding this comment.
could we lift this to some global .props, so we don't need to duplicate it in the iOS/Android/WASM sample .csprojs?
There was a problem hiding this comment.
@steveisok mentioned that eventually the sample projects will be moved into libraries IIRC
|
FYI: @joperezr as this might help you for the linker tests effort. |
| <MicrosoftNetCoreAppRefPackDataDir>$([MSBuild]::NormalizeDirectory('$(MicrosoftNetCoreAppRefPackDir)', 'data'))</MicrosoftNetCoreAppRefPackDataDir> | ||
|
|
||
| <MicrosoftNetCoreAppRuntimePackDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsBinDir)', 'microsoft.netcore.app.runtime.$(PackageRID)', '$(Configuration)'))</MicrosoftNetCoreAppRuntimePackDir> | ||
| <MicrosoftNetCoreAppRuntimePackRidDir>$([MSBuild]::NormalizeDirectory('$(MicrosoftNetCoreAppRuntimePackDir)', 'runtimes', '$(PackageRID)'))</MicrosoftNetCoreAppRuntimePackRidDir> |
There was a problem hiding this comment.
NIT: Do we really need to rename all these variables? Seems like the only runtime pack we are producing is for netcoreapp anyways and we are only really using it in very few places so not sure if we are gaining much by making the property names longer. (Of course I specifically ask this because my linker test functionality depends on the property :+1 but I'm happy to change it if the decision is to rename)
There was a problem hiding this comment.
I prefer an unambiguous meaning as we might introduce a second runtime pack in the future for assets outside of microsoft.netcore.app when we decide to clean the current runtime pack up to only include assets that are part of the shared framework to actually test what we are shipping.
|
@ViktorHofer I tried to run iOS and Android tests on this branch to make sure we don't regress them and they both failed to generate the app bundles. iOSIt seems like we're missing the include assets in the runtime pack. Androidlibmonosgen-2.0 is not in the runtime pack so it is missing on the publish dir. Marking as no merge in the meantime. |
safern
added
the
NO-MERGE
ViktorHofer
removed
the
NO-MERGE
Thanks a lot Santi. Fixed this with 23dfc4e and tested it with Android by following these instructions: https://github.com/dotnet/runtime/blob/master/docs/workflow/testing/libraries/testing-android.md. |
|
Failure is #37635 |
ghost
locked as resolved and limited conversation to collaborators
Binplace reference assemblies into a Microsoft.NetCore.App.Ref folder
and also copy data files like the RuntimeList.xml and the
PlatformManifest.txt there.
Rename the runtime pack to microsoft.netcore.app.runtime.$(RID) and always build it.
Fixing a restore issue in the wasm builder (restore and build should
not happen in the same msbuild invocation).
The ref pack will be consumed in #35606.
cc @ericstj