Support the Encoding enumeration in the Encoding Providers #37528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
@layomia @krwq @GrabYourPitchforks could you please have a look? Thanks. @joperezr could you please help the changes in the csproj files as we started to support netcoreapp for this library? Thanks. |
stephentoub
reviewed
Jun 6, 2020
src/libraries/System.Private.CoreLib/src/System/Text/Encoding.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 6, 2020
src/libraries/System.Private.CoreLib/src/System/Text/EncodingInfo.cs
Outdated
Show resolved
Hide resolved
lindexi
reviewed
Jun 6, 2020
src/libraries/System.Private.CoreLib/src/System/Text/EncodingProvider.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 6, 2020
src/libraries/System.Private.CoreLib/src/System/Text/EncodingInfo.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 6, 2020
src/libraries/System.Private.CoreLib/src/System/Text/EncodingProvider.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 6, 2020
src/libraries/System.Private.CoreLib/src/System/Text/EncodingProvider.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 6, 2020
src/libraries/System.Private.CoreLib/src/System/Text/EncodingTable.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 6, 2020
src/libraries/System.Private.CoreLib/src/System/Text/EncodingTable.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 6, 2020
src/libraries/System.Private.CoreLib/src/System/Text/EncodingTable.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 6, 2020
src/libraries/System.Text.Encoding.CodePages/src/System/Text/EncodingNLS.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jun 6, 2020
src/libraries/System.Text.Encoding.CodePages/src/System/Text/EncodingNLS.cs
Outdated
Show resolved
Hide resolved
|
@stephentoub thanks for the feedback. I think I have addressed all of them by applying your suggestions. let me know if you have any more feedback or we are good to go. |
joperezr
reviewed
Jun 8, 2020
src/libraries/System.Text.Encoding.CodePages/ref/System.Text.Encoding.CodePages.csproj
Show resolved
Hide resolved
joperezr
reviewed
Jun 8, 2020
|
@stephentoub please let me know if you have any other comments. This is pending your approval now. Thanks. |
stephentoub
approved these changes
Jun 8, 2020
src/libraries/System.Private.CoreLib/src/System/Text/EncodingInfo.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Text/EncodingInfo.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Text/EncodingInfo.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Text/EncodingTable.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Text/EncodingTable.cs
Outdated
Show resolved
Hide resolved
GrabYourPitchforks
approved these changes
Jun 8, 2020
src/libraries/System.Text.Encoding.CodePages/src/System/Text/BaseCodePageEncoding.netcoreapp.cs
Outdated
Show resolved
Hide resolved
|
I had two cleanup nits, but nothing that should block checkin. Thanks Tarek for getting to this. :) |
GrabYourPitchforks
approved these changes
Jun 8, 2020
|
I created a new issue for the CI failure on OSX failure #37629 |
akoeplinger
added a commit
to akoeplinger/runtime
that referenced
this pull request
Jun 16, 2020
…s not supported Those sneaked in with dotnet#37528 which was merged at the same time as my PR.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25819
This change allows the encoding providers to enumerate its supported encoding through
EncodingProvider.GetEncodings()method and havingEncoding.GetEncodings()list all encodings from all registered providers.Also, the change fixes the Encoding.BodyName and Encoding.HeaderName properties in our EncodingCodePageProvider implementation to return correct values instead of throwing.