Skip to content

Initialize AsnEncodedData.RawData to empty array #37598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2020
Merged

Initialize AsnEncodedData.RawData to empty array #37598

merged 1 commit into from
Jun 9, 2020

Conversation

stephentoub
Copy link
Member

Maintains nullable annotation on RawData.
Replaces #37572

@bartonjs, if you're not comfortable with the cases that became exceptional, I'm going to punt and let you fix it ;-)

@ghost
Copy link

ghost commented Jun 8, 2020

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq
Notify danmosemsft if you want to be subscribed.

@stephentoub stephentoub mentioned this pull request Jun 8, 2020
Closed
@bartonjs bartonjs added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Jun 8, 2020
bartonjs
bartonjs approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@bartonjs bartonjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mildly hesitant; but the cases that throw now seem exceedingly rare compared to the cases that matter.

@stephentoub
Initialize AsnEncodedData.RawData to empty array
fccc636 
Maintains nullable annotation on RawData.
@stephentoub stephentoub merged commit 1d4f364 into dotnet:master Jun 9, 2020
@stephentoub stephentoub deleted the asnrawdata branch June 9, 2020 00:11
@stephentoub
Copy link
Member Author

Ok.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bartonjs bartonjs bartonjs approved these changes

Assignees
No one assigned
Labels
area-System.Security breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephentoub @bartonjs @Dotnet-GitSync-Bot