-
Notifications
You must be signed in to change notification settings - Fork 3.4k
chore(launchpad): launchpad UI tweaks #18369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(launchpad): launchpad UI tweaks #18369
Conversation
|
Thanks for taking the time to open a PR!
|
JessicaSachs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny typo that I fixed. Otherwise, good. Mark and I paired on doing this.
…press-io/cypress into UNIFY-378-launchpad-ui-tweaks
lmiller1990
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we verify launchpad CT tests are passing locally before merging? Thanks
…nent-tests * unified-desktop-gui: chore(launchpad): launchpad UI tweaks (#18369)
* unified-desktop-gui: chore: improving component test infra (#18378) chore(launchpad): launchpad UI tweaks (#18369) feat: wire up add project button (#18320) feat(unify): adding larger defaults for the Launchpad window (#18248) fix(app): allow launching app dev server w/o relying on `supportFile` to bundle deps (#18354) feat(unify): reporter dark theme (#18313) feat(launchpad): UNIFY-371 header menu (#18338)
Additional details
This PR fixes the images in the component testing framework picker, improves the Switch and Button components to be more consistent with the specific variations present in the designs in Figma, and tweaks colors and spacing throughout launchpad to better align with Figma.
In more detail, this PR:
namepropInstallDependencies- the hope was to close https://cypress-io.atlassian.net/browse/UNIFY-355 but the image in that ticket is old and there is a new design to implement. Still the changes here are in the right direction so I left them in.:rolepreviously weren't valid roles, I've renamed that prop tofunction, it seems like it will come in handy when content arrives for those cards but isn't doing anything atm.How has the user experience changed?
More things match Figma and keyboard behavior is improved, eg: the switch is now represented like this in the accessibility tree: