feat: wire up add project button #18320
Conversation
|
Thanks for taking the time to open a PR!
|
| aria-controls="fileupload" | ||
| prefix-icon-class="text-center justify-center text-lg" | ||
| class="w-20% min-w-120px text-size-16px h-full focus-within:ring-2 focus-within:ring-offset-2 focus-within:ring-indigo-500" | ||
| @click="$emit('new-project')" |
There was a problem hiding this comment.
I think I've removed two of these emits in PR's and wanted to make sure I wasn't getting rid of some vue idiom.
JessicaSachs
left a comment
JessicaSachs
left a comment
There was a problem hiding this comment.
Needs some more tests. I have some suggestions. Essentially, you should refactor the Header a bit to emit add-project and let the parent (whose UI would be updated anyway by graphql behind the scenes) call addProject. This makes the component testable.
| <input | ||
| ref="fileInputRef" | ||
| type="file" | ||
| class="hidden" | ||
| webkitdirectory | ||
| webkit-relative-path | ||
| @change="handleFileSelection" | ||
| > |
There was a problem hiding this comment.
This should probably be pulled out into a composable fn or other kind of component, but we'll wait until we use it again.
| aria-controls="fileupload" | ||
| prefix-icon-class="text-center justify-center text-lg" | ||
| class="w-20% min-w-120px text-size-16px h-full focus-within:ring-2 focus-within:ring-offset-2 focus-within:ring-indigo-500" | ||
| @click="$emit('new-project')" |
Co-authored-by: Jessica Sachs <jess@jessicasachs.io>
Co-authored-by: Jessica Sachs <jess@jessicasachs.io>
tgriesser
left a comment
tgriesser
left a comment
There was a problem hiding this comment.
Still looking into the mutation testing, will hopefully have an update soon
Make sure to merge unified-desktop-gui into this branch to be up-to-date with the latest changes (just updated the branch protection rules so it shows that button)
…ire-add-project-button
tgriesser
requested review from
BlueWinds and
jennifer-shehane
and removed request for
a team
…nent-tests * unified-desktop-gui: feat: wire up add project button (#18320)
* unified-desktop-gui: chore: improving component test infra (#18378) chore(launchpad): launchpad UI tweaks (#18369) feat: wire up add project button (#18320) feat(unify): adding larger defaults for the Launchpad window (#18248) fix(app): allow launching app dev server w/o relying on `supportFile` to bundle deps (#18354) feat(unify): reporter dark theme (#18313) feat(launchpad): UNIFY-371 header menu (#18338)
Connect add project button to mutation
Demo
Add.Project.Demo.mov
How to Test
yarn devat rootPR Tasks
cypress-documentation?type definitions?cypress.schema.json?