fix(app): allow launching app dev server w/o relying on supportFile to bundle deps
#18354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for taking the time to open a PR!
|
JessicaSachs
approved these changes
Oct 5, 2021
tgriesser
added a commit
that referenced
this pull request
Oct 6, 2021
* unified-desktop-gui: chore: improving component test infra (#18378) chore(launchpad): launchpad UI tweaks (#18369) feat: wire up add project button (#18320) feat(unify): adding larger defaults for the Launchpad window (#18248) fix(app): allow launching app dev server w/o relying on `supportFile` to bundle deps (#18354) feat(unify): reporter dark theme (#18313) feat(launchpad): UNIFY-371 header menu (#18338)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://cypress-io.atlassian.net/browse/UNIFY-417
This allows serving the new
appwithout relying onsupportFileto force Vite to pre-bundle the dependencies required (such as@urql/vue).I am not clear on why doing
import ... from '@packages/frontend-shared/......does not correctly bundle the dependencies. We should find out why, but for now, I just worked around it usingoptimizeas suggested by the official Vite docs. This unblocks my work in the spike into runner ui ticket.