-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat(launchpad): UNIFY-371 header menu #18338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for taking the time to open a PR!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. There's a ton of type failures and lint issues that need to be dealt with.
Aside from those, there are four types of changes to make:
rem/em => pxfor all CSS values- Swapping out any english strings and putting them into en-US.json
- Within TopNav, useTimeAgo for the dates.
- Within TopNav, adding a
currentproperty to browserVersions and using that instead of!!indexetc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes.
* unified-desktop-gui: chore: improving component test infra (#18378) chore(launchpad): launchpad UI tweaks (#18369) feat: wire up add project button (#18320) feat(unify): adding larger defaults for the Launchpad window (#18248) fix(app): allow launching app dev server w/o relying on `supportFile` to bundle deps (#18354) feat(unify): reporter dark theme (#18313) feat(launchpad): UNIFY-371 header menu (#18338)
Additional details
This PR:
target="_blank"and open their href in the default OS browser via graphql mutation, looking for feedback on this idea vs something more explicit ([target="external"]?), and some help on the required mutation to get this going.How has the user experience changed?
Menus have been added to the header bar in Launch Pad, here's an example with the browser list added for demo purposes:
top.nav.mov
How to test
Pull down this branch and run
yarn devin thelaunchpaddirectory. The menu should now exist in the top right of the launchpad. To test the populated browser menu, edit Main.vue to add:show-browsers="true"to the tag forHeaderBar.PR Tasks