Skip to content

Conversation

@marktnoonan
Copy link
Contributor

Additional details

This PR:

  • fixes a hex code in the color tokens
  • updates the icon-color-plugin to import our custom colors
  • extracts the browser logo imports to a single place so that anywhere that needs them can look them up. This was done in favor of a composable that would link them to graphql after talking with Tim. OpenBrowserList has been refactored to import this.
  • adds some icons
  • adds a click handler to App.vue that would capture all links with target="_blank" and open their href in the default OS browser via graphql mutation, looking for feedback on this idea vs something more explicit ([target="external"]?), and some help on the required mutation to get this going.
  • adds a Top Nav component and some smaller child components
  • adds a transitions folder for reusable transitions since the way of applying this with tailwind's syntax is pretty verbose, but also it's nice to just wrap things in a component to get consistent transitions around the app
  • tests the new components via adding a component test for the whole header bar to get graphql mocking working

How has the user experience changed?

Menus have been added to the header bar in Launch Pad, here's an example with the browser list added for demo purposes:

top.nav.mov

How to test

Pull down this branch and run yarn dev in the launchpad directory. The menu should now exist in the top right of the launchpad. To test the populated browser menu, edit Main.vue to add :show-browsers="true" to the tag for HeaderBar.

PR Tasks

  • [z] Have tests been added/updated?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 1, 2021

Thanks for taking the time to open a PR!

@JessicaSachs JessicaSachs self-requested a review October 1, 2021 22:08
Copy link
Contributor

@JessicaSachs JessicaSachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. There's a ton of type failures and lint issues that need to be dealt with.

Aside from those, there are four types of changes to make:

  1. rem/em => px for all CSS values
  2. Swapping out any english strings and putting them into en-US.json
  3. Within TopNav, useTimeAgo for the dates.
  4. Within TopNav, adding a current property to browserVersions and using that instead of !!index etc

@marktnoonan marktnoonan changed the title UNIFY-371 header menu feat:(launchpad) UNIFY-371 header menu Oct 4, 2021
@marktnoonan marktnoonan changed the title feat:(launchpad) UNIFY-371 header menu feat(launchpad): UNIFY-371 header menu Oct 4, 2021
@JessicaSachs JessicaSachs self-requested a review October 4, 2021 20:43
Copy link
Contributor

@JessicaSachs JessicaSachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes.

@JessicaSachs JessicaSachs merged commit 999a68d into unified-desktop-gui Oct 4, 2021
tgriesser added a commit that referenced this pull request Oct 6, 2021
* unified-desktop-gui:
  chore: improving component test infra (#18378)
  chore(launchpad): launchpad UI tweaks (#18369)
  feat: wire up add project button (#18320)
  feat(unify): adding larger defaults for the Launchpad window (#18248)
  fix(app): allow launching app dev server w/o relying on `supportFile` to bundle deps (#18354)
  feat(unify): reporter dark theme (#18313)
  feat(launchpad): UNIFY-371 header menu (#18338)
@jennifer-shehane jennifer-shehane deleted the UNIFY-371-header-menu branch August 28, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants