feat(unify): adding larger defaults for the Launchpad window #18248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w launchpad designs
Contributor
|
Thanks for taking the time to open a PR!
|
JessicaSachs
requested review from
chrisbreiding and
jennifer-shehane
and removed request for
a team
JessicaSachs
requested review from
elevatebart and
lmiller1990
and removed request for
chrisbreiding and
jennifer-shehane
ZRDKPoWeR
approved these changes
Sep 26, 2021
Contributor
|
I think this PR should be made against develop and back-merged? As for testing: Test 1 - new users This is the max height/with for launchpad now:
Test 2 I am not getting the expected result for the second test, though. It's remembering and keeping the size I dragged it to, even after reopening:
|
Contributor
Author
|
It shouldn't be back merged because the new dimensions only look good with the new UI. |
Contributor
|
@JessicaSachs makes sense. Maybe I misread the test plan or something, could do a quick pair review when our hours overlap and get this in. |
tgriesser
added a commit
that referenced
this pull request
Oct 6, 2021
* unified-desktop-gui: chore: improving component test infra (#18378) chore(launchpad): launchpad UI tweaks (#18369) feat: wire up add project button (#18320) feat(unify): adding larger defaults for the Launchpad window (#18248) fix(app): allow launching app dev server w/o relying on `supportFile` to bundle deps (#18354) feat(unify): reporter dark theme (#18313) feat(launchpad): UNIFY-371 header menu (#18338)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The new Launchpad designs are not designed to work in a very small window. This PR sets a new minimum width and height as well as a new
preferredWidthandpreferredHeightto support first time users and older users whose previous window values were below the new minimums.While I was in the Windows options, I also changed the backgroundColor to match what the Launchpad's backgroundColor is... so it doesn't flash between gray and white.
How to test
New Users
Existing Users
interactive-e2e#getWindowArgsto have a smaller minWidth + height.yarn devyarn devand revert any changesyarn devExpected: The Launchpad app should be set to the
preferredWidthandpreferredHeightHow has the user experience changed?
Better window size defaults. No background color flash when starting up the Launchpad.
Considerations
We aren't setting the x/y coordinates for first time users of the new version. I think it should probably be centered, but I don't want to do that change right now.