Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Resolve Warnings in Action Summary #7473

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Resolve Warnings in Action Summary #7473

wants to merge 2 commits into from

Conversation

MinerSebas
Copy link
Contributor

@MinerSebas MinerSebas commented Feb 2, 2023 •
edited
Loading

Objective

Solution

  • Remove the invalid override input.
  • Update actions/cache@v2 to actions/cache@v3.

@MinerSebas MinerSebas changed the title Resolve Warnings in from Action Summary Resolve Warnings in Action Summary Feb 2, 2023
@MinerSebas
Copy link
Contributor Author

Compare this now with https://github.com/bevyengine/bevy/actions/runs/4075539199 , whic only has the mac-os version change:
Screenshot_20230202_154955

@mockersf mockersf added A-Build-System Related to build systems or continuous integration S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Feb 2, 2023
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 2, 2023
@MinerSebas
Resolve Warnings in Action Summary (#7473)
e039825 
# Objective

- The CI Summary shows several fixable Warnings.
Example from https://github.com/bevyengine/bevy/actions/runs/4075078887:
![Screenshot_20230202_152644](https://user-images.githubusercontent.com/66798382/216352644-62e9664b-c881-4bc5-9a80-694cef25df76.png)

- The Job `check-compiles` provided an invalid input.
- The Job `check-doc` uses an outdated Version of `actions/cache`.

## Solution

- Remove the invalid `override` input.
- Update `actions/cache@v2` to `actions/cache@v3`.
@bors
Copy link
Contributor

bors bot commented Feb 2, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Resolve Warnings in Action Summary [Merged by Bors] - Resolve Warnings in Action Summary Feb 2, 2023
@bors bors bot closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rparrett rparrett rparrett approved these changes

@mockersf mockersf mockersf approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MinerSebas @alice-i-cecile @rparrett @mockersf