Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting small things here and there.. #706

Merged
merged 9 commits into from
Oct 21, 2020

Conversation

CGMossa
Copy link
Contributor

@CGMossa CGMossa commented Oct 20, 2020

Hey! I've just started using Bevy by following Snake tutorial and I'm just tinkering with documenting some things here and there.

Please provide feedback.

@CGMossa
Copy link
Contributor Author

CGMossa commented Oct 21, 2020

Thanks for the additions. I'll push them in a second.

The CI fails if my file isn't rustfmt'd, but if a I run cargo fmt inside of bevy, then all the
files gets modified.. I guess, should I push a commit that has formatted every bevy file using cargo fmt?

@karroffel karroffel added the C-Docs An addition or correction to our documentation label Oct 21, 2020
@CGMossa
Copy link
Contributor Author

CGMossa commented Oct 21, 2020

The CI fails if my file isn't rustfmt'd, but if a I run cargo fmt inside of bevy, then all the
files gets modified.. I guess, should I push a commit that has formatted every bevy file using cargo fmt?

Never mind. I figured that it was a windows thing. I am using different line endings than Unix. I changed
rustfmt.toml line to newline_style = "Native", and that worked fine. I won't commit this change..
But these line endings might come from GIT, maybe?

@cart cart marked this pull request as ready for review October 21, 2020 19:53
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
@cart cart merged commit 58eb7e7 into bevyengine:master Oct 21, 2020
@CGMossa CGMossa deleted the tiny_documentation branch April 1, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Docs An addition or correction to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants