Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - allow unicode license #5337

Closed
wants to merge 2 commits into from

Conversation

mockersf
Copy link
Member

Objective

Solution

  • The license should be ok for Bevy, add it to the allowed licenses

@mockersf mockersf requested a review from DJMcNab July 16, 2022 08:40
@DJMcNab
Copy link
Member

DJMcNab commented Jul 16, 2022

I'd rather keep it 'contained', i.e. only allow this specific license for the one specific crate, using an exception.

I do agree though that this seems fine to me.
Why do we use this crate?

@bjorn3
Copy link
Contributor

bjorn3 commented Jul 16, 2022

unicode-xid (which is part of unicode-ident) is used by proc-macro2 and syn.

@alice-i-cecile alice-i-cecile added A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior labels Jul 16, 2022
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay to allow this: appears to be a very lightly modified MIT.

@DJMcNab
Copy link
Member

DJMcNab commented Jul 16, 2022

The fact that we're not shipping it in binaries also makes me happier, however I still think we should only allow this one crate.

Really, what I want is EmbarkStudios/cargo-deny#413, for build dependencies. Not sure how much wrangling that would require.

@mockersf
Copy link
Member Author

mockersf commented Jul 16, 2022

I'd rather keep it 'contained', i.e. only allow this specific license for the one specific crate, using an exception.

Sounds good!

Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't have EmbarkStudios/cargo-deny#413, I'm happy with this.

@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jul 17, 2022
# Objective

- Crate `unicode-ident` added the [unicode license](https://github.com/dtolnay/unicode-ident/blob/master/LICENSE-UNICODE). See https://github.com/dtolnay/unicode-ident#license. The only requirement seems to be to include the license in the distribution
- This makes license check fail

## Solution

- The license should be ok for Bevy, add it to the allowed licenses
@bors bors bot changed the title allow unicode license [Merged by Bors] - allow unicode license Jul 17, 2022
@bors bors bot closed this Jul 17, 2022
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
# Objective

- Crate `unicode-ident` added the [unicode license](https://github.com/dtolnay/unicode-ident/blob/master/LICENSE-UNICODE). See https://github.com/dtolnay/unicode-ident#license. The only requirement seems to be to include the license in the distribution
- This makes license check fail

## Solution

- The license should be ok for Bevy, add it to the allowed licenses
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
# Objective

- Crate `unicode-ident` added the [unicode license](https://github.com/dtolnay/unicode-ident/blob/master/LICENSE-UNICODE). See https://github.com/dtolnay/unicode-ident#license. The only requirement seems to be to include the license in the distribution
- This makes license check fail

## Solution

- The license should be ok for Bevy, add it to the allowed licenses
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

- Crate `unicode-ident` added the [unicode license](https://github.com/dtolnay/unicode-ident/blob/master/LICENSE-UNICODE). See https://github.com/dtolnay/unicode-ident#license. The only requirement seems to be to include the license in the distribution
- This makes license check fail

## Solution

- The license should be ok for Bevy, add it to the allowed licenses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants