-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - allow unicode license #5337
Conversation
I'd rather keep it 'contained', i.e. only allow this specific license for the one specific crate, using an exception. I do agree though that this seems fine to me. |
unicode-xid (which is part of unicode-ident) is used by proc-macro2 and syn. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay to allow this: appears to be a very lightly modified MIT.
The fact that we're not shipping it in binaries also makes me happier, however I still think we should only allow this one crate. Really, what I want is EmbarkStudios/cargo-deny#413, for build dependencies. Not sure how much wrangling that would require. |
Sounds good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we don't have EmbarkStudios/cargo-deny#413, I'm happy with this.
bors r+ |
# Objective - Crate `unicode-ident` added the [unicode license](https://github.com/dtolnay/unicode-ident/blob/master/LICENSE-UNICODE). See https://github.com/dtolnay/unicode-ident#license. The only requirement seems to be to include the license in the distribution - This makes license check fail ## Solution - The license should be ok for Bevy, add it to the allowed licenses
Pull request successfully merged into main. Build succeeded: |
# Objective - Crate `unicode-ident` added the [unicode license](https://github.com/dtolnay/unicode-ident/blob/master/LICENSE-UNICODE). See https://github.com/dtolnay/unicode-ident#license. The only requirement seems to be to include the license in the distribution - This makes license check fail ## Solution - The license should be ok for Bevy, add it to the allowed licenses
# Objective - Crate `unicode-ident` added the [unicode license](https://github.com/dtolnay/unicode-ident/blob/master/LICENSE-UNICODE). See https://github.com/dtolnay/unicode-ident#license. The only requirement seems to be to include the license in the distribution - This makes license check fail ## Solution - The license should be ok for Bevy, add it to the allowed licenses
# Objective - Crate `unicode-ident` added the [unicode license](https://github.com/dtolnay/unicode-ident/blob/master/LICENSE-UNICODE). See https://github.com/dtolnay/unicode-ident#license. The only requirement seems to be to include the license in the distribution - This makes license check fail ## Solution - The license should be ok for Bevy, add it to the allowed licenses
Objective
unicode-ident
added the unicode license. See https://github.com/dtolnay/unicode-ident#license. The only requirement seems to be to include the license in the distributionSolution