Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State Reloading #3830

Closed
wants to merge 2 commits into from
Closed

Conversation

ManevilleF
Copy link
Contributor

@ManevilleF ManevilleF commented Jan 31, 2022

Objective

Current state scheduling prevents same-state transitions, aka state reloading.
The state reloading can be very useful to reset levels or boards for example

Solution

  • I removed the same state error and verification
  • Every state overwrite_ method is no longer faillible (breaking change)
  • I added a test for state reloading

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Jan 31, 2022
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible and removed S-Needs-Triage This issue needs to be labelled labels Jan 31, 2022
@cart
Copy link
Member

cart commented Feb 4, 2022

Looks like #3328 (which we just merged) accomplishes the same goal. Does that work for you?

@ManevilleF
Copy link
Contributor Author

Fine by me

@ManevilleF ManevilleF closed this Feb 4, 2022
@ManevilleF ManevilleF deleted the feat/stage_reload branch June 22, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Feature A new feature, making something new possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants