Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - remove commented code and TODO as it's not actually possible #2289

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - remove commented code and TODO as it's not actually possible #2289

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Jun 1, 2021

Fixing it was tried in #2069 and deemed not possible (#2069 (comment))

Other possibility would be to change the TODO to note the dependency on chalk integration.

@mockersf mockersf added the C-Code-Quality A section of code that is hard to understand or change label Jun 1, 2021
@cart
Copy link
Member

cart commented Jun 2, 2021

bors r+

bors bot pushed a commit that referenced this pull request Jun 2, 2021
@mockersf
remove commented code and TODO as it's not actually possible (#2289)
6301b72 
Fixing it was tried in #2069 and deemed not possible (#2069 (comment))

Other possibility would be to change the TODO to note the dependency on chalk integration.
@bors
Copy link
Contributor

bors bot commented Jun 2, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title remove commented code and TODO as it's not actually possible [Merged by Bors] - remove commented code and TODO as it's not actually possible Jun 2, 2021
@bors bors bot closed this Jun 2, 2021
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
@mockersf @ostwilkens
remove commented code and TODO as it's not actually possible (bevyeng…
e3c62a5 
…ine#2289)

Fixing it was tried in bevyengine#2069 and deemed not possible (bevyengine#2069 (comment))

Other possibility would be to change the TODO to note the dependency on chalk integration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanSWard NathanSWard NathanSWard approved these changes

Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @cart @NathanSWard