Added derive Reflect to UntypedHandle and UntypedAssetId #18827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
andriyDev
approved these changes
Apr 13, 2025
djeedai
approved these changes
Apr 19, 2025
djeedai
added
C-Feature
andriyDev
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Apr 28, 2025
splo
pushed a commit
to splo/bevy
that referenced
this pull request
Apr 29, 2025
…18827) # Objective - We have the ability to serialize/deserialize `Handle<T>` with [`TypedReflectSerializer`](https://docs.rs/bevy/latest/bevy/reflect/serde/struct.TypedReflectSerializer.html) and [`TypedReflectDeserializer`](https://docs.rs/bevy/latest/bevy/reflect/serde/struct.TypedReflectDeserializer.html), but it is not possible for `UntypedHandle`. - `Handle<T>` already has the `Reflect` derive, so it sounds coherent to also have this derive also on the untyped API ## Solution - Add the `Reflect` derive macro to both `UntypedHandle` and ` UntypedAssetId`. ## Testing - I used a custom processor to handle the serialization based on the example of [`TypedReflectSerializer`](https://docs.rs/bevy/latest/bevy/reflect/serde/struct.TypedReflectSerializer.html) (see [source code](https://docs.rs/bevy_reflect/0.15.3/src/bevy_reflect/serde/ser/serializer.rs.html#149)) Co-authored-by: Frédéric Vauchelles <frederic.vauchelles@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Handle<T>withTypedReflectSerializerandTypedReflectDeserializer, but it is not possible forUntypedHandle.Handle<T>already has theReflectderive, so it sounds coherent to also have this derive also on the untyped APISolution
Reflectderive macro to bothUntypedHandleandUntypedAssetId.Testing
TypedReflectSerializer(see source code)