Skip to content

Move initializing the ScreenshotToScreenPipeline to the ScreenshotPlugin. #18524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move initializing the ScreenshotToScreenPipeline to the ScreenshotPlugin. #18524

wants to merge 1 commit into from
+2 −7

Conversation

andriyDev
Copy link
Contributor

Objective

  • Minor cleanup.
  • This seems to have been introduced in Webgpu support #8336. There is no discussion about it I can see, there's no comment explaining why this is here and not in ScreenshotPlugin. This seems to have just been misplaced.

Solution

  • Move this to the ScreenshotPlugin!

Testing

  • The screenshot example still works at least on desktop.

@andriyDev andriyDev marked this pull request as ready for review March 25, 2025 00:55
@andriyDev andriyDev added D-Trivial Nice and easy! A great choice to get started with Bevy A-Windowing Platform-agnostic interface layer to run your app in S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Mar 25, 2025
@andriyDev andriyDev requested a review from mockersf March 25, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf Awaiting requested review from mockersf

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andriyDev