Cleaner macros utilizing syn::Member

[Bleachfuel]

Objective

Some macros were handling Idents and indexes as seperate things, we can use syn::Member to make this more readable and nicer.

Testing

ran all revelant crate tests.

[Bleachfuel]

#[derive(QueryData)]
#[query_data(mutable(foo))]
//~^ ERROR: `mutable` does not take any arguments
struct MutableInvalidAttributeParameters {
    a: &'static mut Foo,
}

should we really give a error for this? seems so unnessesary and extra code. When u do this it already says "expected ,". I removed 2 of them, since the errors that syn gives are already clear. Maybe even clearer.

[chescock]

Yeah, this seems cleaner!

It's a little unfortunate that syn::Member doesn't have the rest of the Field value, forcing most of the uses here to do fields.iter().enumerate().filter().map() instead of just field.members(). Would it ever make sense to add our own wrapper type around a &Field and its index, along with a function to iterate them from a Fields, so that we could share a little more code here?

[Bleachfuel]

Yeah we could do that, but would be better as a follow up pr

[james7132]

This is so much cleaner! LGTM.

[alice-i-cecile]

@Bleachfuel, I would rather like to merge this, but the merge conflicts are non-trivial. Could you take a look?

[alice-i-cecile]

CI is still failing unfortunately :(

[github-actions]

Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke!
You can review it at https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D?filter=PR-18199

If it's expected, please add the M-Deliberate-Rendering-Change label.

If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it.

[github-actions]

Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke!
You can review it at https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D?filter=PR-18199

If it's expected, please add the M-Deliberate-Rendering-Change label.

If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it.

[alice-i-cecile]

Closing as adopted.