feedback

Author: Bleachfuel

crates/bevy_ecs/macros/src/lib.rs

@@ -319,10 +319,10 @@ fn derive_system_param_impl(
     let generics = ast.generics;
 
     // Emit an error if there's any unrecognized lifetime names.
+    let w = format_ident!("w");
+    let s = format_ident!("s");
     for lt in generics.lifetimes() {
         let ident = &lt.lifetime.ident;
-        let w = format_ident!("w");
-        let s = format_ident!("s");
         if ident != &w && ident != &s {
             return Err(syn::Error::new_spanned(
                 lt,

crates/bevy_ecs/macros/src/query_data.rs

@@ -130,7 +130,7 @@ pub fn derive_query_data_impl(input: TokenStream) -> TokenStream {
     for (i, field) in fields.iter().enumerate() {
         field_attrs.push(field.attrs.clone());
         field_visibilities.push(field.vis.clone());
-        field_idents.push(field.ident.clone().unwrap_or(format_ident!("f{i}")));
+        field_idents.push(field.ident.clone().unwrap_or_else(|| format_ident!("f{i}")));
 
         let field_ty = field.ty.clone();
         field_types.push(quote!(#field_ty));