Skip to content

Add a Sphere to anisotropy example #17676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 5, 2025
Merged

Add a Sphere to anisotropy example #17676

merged 5 commits into from
Feb 5, 2025

Conversation

@hukasu
Copy link
Contributor

@hukasu hukasu commented Feb 4, 2025

Objective

Add a mesh with a more regular shape to visualize the anisotropy effect.

Solution

Add a Sphere to the scene.

Testing

Ran anisotropy example

Showcase

image

image

Note: defects are already mentioned on #16179

@rparrett rparrett self-requested a review February 4, 2025 13:26
rparrett
rparrett suggested changes Feb 4, 2025
View reviewed changes
rparrett
rparrett reviewed Feb 4, 2025
View reviewed changes
rparrett
rparrett reviewed Feb 4, 2025
View reviewed changes
rparrett
rparrett reviewed Feb 4, 2025
View reviewed changes
@rparrett rparrett added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 4, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 5, 2025
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it C-Testing A change that impacts how we test Bevy or how users test their apps and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 5, 2025
Merged via the queue into bevyengine:main with commit fdc7cb3 Feb 5, 2025
33 checks passed
@hukasu hukasu deleted the add-sphere-to-anisotropy-example branch February 5, 2025 20:44
mrchantey pushed a commit to mrchantey/bevy that referenced this pull request Feb 17, 2025
@hukasu @mrchantey
Add a Sphere to anisotropy example (bevyengine#17676)
d9970d3 
# Objective

Add a mesh with a more regular shape to visualize the anisotropy effect.

## Solution

Add a `Sphere` to the scene.

## Testing

Ran `anisotropy` example

## Showcase


![image](https://github.com/user-attachments/assets/9bf20c61-5626-49fc-bc4a-c8e2f2309a8a)


![image](https://github.com/user-attachments/assets/649a32ad-a260-44b1-ad73-b7a660a110a3)

Note: defects are already mentioned on bevyengine#16179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@rparrett rparrett rparrett approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples C-Testing A change that impacts how we test Bevy or how users test their apps S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hukasu @rparrett @alice-i-cecile