Test benchmarks in CI #16987
Merged
Test benchmarks in CI #16987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts bevyengine#16833.
BD103
added
D-Trivial
Contributor
|
Something happened with the bench |
BenjaminBrienen
approved these changes
Dec 26, 2024
tools/ci/src/commands/test.rs
Outdated
| cmd!( | ||
| sh, | ||
| "cargo test --workspace --lib --bins --tests {no_fail_fast}" | ||
| // `--benches` runs each benchmark once, to verify that they behave correctly. |
Contributor
There was a problem hiding this comment.
Suggested change
| // `--benches` runs each benchmark once, to verify that they behave correctly. | |
| // `--benches` runs each benchmark once in order to verify that they behave correctly. (Don't panic) |
Contributor
|
Approving since the failure should be fixed in a separate PR |
Integer overflow panics in debug mode! Let's make it explicitly wrapping, just like how it is in release mode.
Member
Author
Surprisingly not! The panic was an integer overflow that was never caught in our benchmarks because they are usually compiled in release mode. I fixed it in aa2e600, though, to explicitly wrap. |
BenjaminBrienen
approved these changes
Dec 26, 2024
BD103
added
S-Ready-For-Final-Review
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective - This reverts bevyengine#16833, and completely goes against bevyengine#16803. - Turns out running `cargo test --benches` runs each benchmark once, without timing it, just to ensure nothing panics. This is actually desired because we can use it to verify benchmarks are working correctly without all the time constraints of actual benchmarks. ## Solution - Add the `--benches` flag to the CI test command. ## Testing - `cargo run -p ci -- test`
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
# Objective - This reverts bevyengine#16833, and completely goes against bevyengine#16803. - Turns out running `cargo test --benches` runs each benchmark once, without timing it, just to ensure nothing panics. This is actually desired because we can use it to verify benchmarks are working correctly without all the time constraints of actual benchmarks. ## Solution - Add the `--benches` flag to the CI test command. ## Testing - `cargo run -p ci -- test`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
cargo test --benchesruns each benchmark once, without timing it, just to ensure nothing panics. This is actually desired because we can use it to verify benchmarks are working correctly without all the time constraints of actual benchmarks.Solution
--benchesflag to the CI test command.Testing
cargo run -p ci -- test