-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Closed
Labels
A-Build-SystemRelated to build systems or continuous integrationRelated to build systems or continuous integrationC-BugAn unexpected or incorrect behaviorAn unexpected or incorrect behaviorD-TrivialNice and easy! A great choice to get started with BevyNice and easy! A great choice to get started with BevyS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!
Description
Our CI tool currently runs cargo test --benches:
bevy/tools/ci/src/commands/test.rs
Line 20 in 00722b8
| "cargo test --workspace --lib --bins --tests --benches {no_fail_fast}" |
Because our benchmarks use a custom harness, though, they do not detect this and just run all benchmarks. This is undesired because benchmarks are lengthy and resource-intensive, and should not contain unit tests. The --benches flag should be removed.
Metadata
Metadata
Assignees
Labels
A-Build-SystemRelated to build systems or continuous integrationRelated to build systems or continuous integrationC-BugAn unexpected or incorrect behaviorAn unexpected or incorrect behaviorD-TrivialNice and easy! A great choice to get started with BevyNice and easy! A great choice to get started with BevyS-Ready-For-ImplementationThis issue is ready for an implementation PR. Go for it!This issue is ready for an implementation PR. Go for it!