Skip to content

Fix stale comment on LoadContext::finish. #16821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2024
Merged

Fix stale comment on LoadContext::finish. #16821

merged 1 commit into from
Dec 15, 2024

Conversation

@andriyDev
Copy link
Contributor

@andriyDev andriyDev commented Dec 14, 2024

Objective

Solution

  • Just delete all the references to the meta field.

@chompaa chompaa added C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy A-Assets Load files from disk to use for things like images, models, and sounds S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 14, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Dec 15, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 15, 2024
Merged via the queue into bevyengine:main with commit 622ca0d Dec 15, 2024
33 checks passed
ecoskey pushed a commit to ecoskey/bevy that referenced this pull request Jan 6, 2025
@andriyDev @ecoskey
Fix stale comment on LoadContext::finish. (bevyengine#16821)
625827b 
# Objective

- The comment is stale after bevyengine#15487.

## Solution

- Just delete all the references to the meta field.
mrchantey pushed a commit to mrchantey/bevy that referenced this pull request Feb 4, 2025
@andriyDev @mrchantey
Fix stale comment on LoadContext::finish. (bevyengine#16821)
0fc1b48 
# Objective

- The comment is stale after bevyengine#15487.

## Solution

- Just delete all the references to the meta field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees

No one assigned

Labels

A-Assets Load files from disk to use for things like images, models, and sounds C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andriyDev @alice-i-cecile @chompaa