Remove the meta field from LoadedAsset and ErasedLoadedAsset.
#15487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminBrienen
added
A-Assets
BenjaminBrienen
approved these changes
Sep 28, 2024
Contributor
Author
|
No change. Just had to resolve a conflict where two changes lines are right next to each other. |
BenjaminBrienen
approved these changes
Dec 11, 2024
cart
approved these changes
Dec 13, 2024
Member
cart
left a comment
cart
left a comment
There was a problem hiding this comment.
Iirc I had a future reason to include this, but we can always add it back if we need it.
This was referenced Dec 14, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 15, 2024
# Objective - The comment is stale after #15487. ## Solution - Just delete all the references to the meta field.
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
…evyengine#15487) # Objective Fixes bevyengine#15485. ## Solution Deletes the field! The `meta` field had no way to access or mutate it. ## Testing - It builds! --- ## Migration Guide - `ErasedAssetLoader` now takes a borrow to `AssetMetaDyn` instead of a `Box`. - `LoadedAsset::new_with_dependencies` no longer requires a `meta` argument. - `LoadContext::finish` no longer requires a `meta` argument.
ecoskey
pushed a commit
to ecoskey/bevy
that referenced
this pull request
Jan 6, 2025
# Objective - The comment is stale after bevyengine#15487. ## Solution - Just delete all the references to the meta field.
mrchantey
pushed a commit
to mrchantey/bevy
that referenced
this pull request
Feb 4, 2025
# Objective - The comment is stale after bevyengine#15487. ## Solution - Just delete all the references to the meta field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #15485.
Solution
Deletes the field! The
metafield had no way to access or mutate it.Testing
Migration Guide
ErasedAssetLoadernow takes a borrow toAssetMetaDyninstead of aBox.LoadedAsset::new_with_dependenciesno longer requires ametaargument.LoadContext::finishno longer requires ametaargument.