Audio sink seek

[ivanstepanovftw]

Objective

• Seeking in audio sink to specific location

Solution

• Using new method fn try_seek(&mut self, pos: Duration) -> Result<(), SeekNotSupported> from rodio.

Related issue: #9076

Testing

• It is not working, help needed.

  /home/i/.cargo/bin/cargo +nightly run --color=always --package bevy --example audio_control --release

    Finished `release` profile [optimized] target(s) in 0.30s
     Running `target/release/examples/audio_control`
2024-06-16T07:42:04.325210Z  INFO bevy_diagnostic::system_information_diagnostics_plugin::internal: SystemInfo { os: "Linux 40 Fedora Linux", kernel: "6.8.11-300.fc40.x86_64", cpu: "AMD Ryzen 7 5800U with Radeon Graphics", core_count: "8", memory: "14.5 GiB" }
2024-06-16T07:42:04.451561Z  INFO bevy_render::renderer: AdapterInfo { name: "AMD Radeon Graphics (RADV RENOIR)", vendor: 4098, device: 5688, device_type: IntegratedGpu, driver: "radv", driver_info: "Mesa 24.1.1", backend: Vulkan }
2024-06-16T07:42:04.852471Z  INFO bevy_winit::system: Creating new window "App" (Entity { index: 0, generation: 1 })
2024-06-16T07:42:04.853166Z  INFO winit::platform_impl::platform::x11::window: Guessed window scale factor: 2
thread 'Compute Task Pool (1)' panicked at examples/audio/audio_control.rs:62:68:
called `Result::unwrap()` on an `Err` value: NotSupported { underlying_source: "rodio::decoder::vorbis::VorbisDecoder<std::io::cursor::Cursor<bevy_audio::audio_source::AudioSource>>" }
stack backtrace:
   0: rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::result::unwrap_failed
   3: core::ops::function::impls::<impl core::ops::function::FnMut<A> for &mut F>::call_mut
   4: <bevy_ecs::system::function_system::FunctionSystem<Marker,F> as bevy_ecs::system::system::System>::run_unsafe
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
Encountered a panic in system `audio_control::seek`!
Encountered a panic in system `bevy_app::main_schedule::Main::run_main`!

Process finished with exit code 101

---

Changelog

Added

• Seeking to specific location in audio sink.

[github-actions]

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

[torsteingrindvik]

https://github.com/RustAudio/rodio/blob/master/src/decoder/vorbis.rs#L90

It looks like seeking is only possible for some audio formats, and vorbis is not one.
So you could consider changing formats until vorbis has support.

EDIT: Whoops I thought this was an issue not a PR

sink.try_seek(std::time::Duration::from_secs_f64(0.0)).unwrap();

The problem then is just that you cannot call .unwrap() since it's fallible and some backends might not support it.

[taj-holliday]

@ivanstepanovftw are you planning on finishing this PR? One of my projects would benefit from this feature, and I'd be willing to adopt if you aren't.

[NthTensor]

Closing as adopted.