-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Explicitly run +nightly
for -Zcheck-cfg
pass in ci.
#12230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am seeing this output locally:
|
rparrett
approved these changes
Mar 1, 2024
doonv
approved these changes
Mar 1, 2024
Note: The PR for |
mockersf
approved these changes
Mar 1, 2024
Perhaps in the future it would be nice to check whether CI is being compiled from a nightly toolchain or not (I'm thinking |
That's what I get from |
spectria-limina
pushed a commit
to spectria-limina/bevy
that referenced
this pull request
Mar 9, 2024
…2230) # Objective Getting this error running ci locally. ``` $ cargo check -Zcheck-cfg --workspace error: the `-Z` flag is only accepted on the nightly channel of Cargo, but this is the `stable` channel See https://doc.rust-lang.org/book/appendix-07-nightly-rust.html for more information about Rust release channels. thread 'main' panicked at tools\ci\src\main.rs:166:14: Please fix failing cfg checks in output above.: command exited with non-zero code `cargo check -Zcheck-cfg --workspace`: 101 ``` ## Solution - Add `+nightly` flag to the `check-cfg` pass. --- Obviously we shouldn't be running `nightly` Cargo, but at least now local running of `cargo run -p ci` will pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Build-System
Related to build systems or continuous integration
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Getting this error running ci locally.
Solution
+nightly
flag to thecheck-cfg
pass.Obviously we shouldn't be running
nightly
Cargo, but at least now local running ofcargo run -p ci
will pass.