Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: readability-identifier-naming for pose history #1641

Merged

Conversation

h-ohta
Copy link
Contributor

@h-ohta h-ohta commented Aug 22, 2022

This reverts commit 9278e71 in #1608 .

Signed-off-by: h-ohta hiroki.ota@tier4.jp

Description

  • revert readability-identifier-naming

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

This reverts commit 9278e71.

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
@h-ohta h-ohta force-pushed the revert/readability-identifier-naming branch from b91d58c to 8b4ac95 Compare August 22, 2022 01:39
@h-ohta h-ohta changed the title revert: readability-identifier-naming" for pose history revert: readability-identifier-naming for pose history Aug 22, 2022
This reverts commit 5e85599.
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1641 (3f865cc) into main (9a1ada0) will not change coverage.
The diff coverage is 21.21%.

@@           Coverage Diff           @@
##             main    #1641   +/-   ##
=======================================
  Coverage   10.65%   10.65%           
=======================================
  Files        1109     1109           
  Lines       78524    78524           
  Branches    18520    18520           
=======================================
  Hits         8363     8363           
  Misses      61309    61309           
  Partials     8852     8852           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.63% <21.21%> (ø) Carriedforward from 9a1ada0

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...z_plugin/src/pose_history/pose_history_display.cpp 0.00% <0.00%> (ø)
...z_plugin/src/pose_history/pose_history_display.hpp 0.00% <ø> (ø)
...city_planner/src/scene_module/blind_spot/scene.cpp 0.00% <0.00%> (ø)
...c/scene_module/intersection/scene_intersection.cpp 0.00% <0.00%> (ø)
...tion_utils/test/src/trajectory/test_trajectory.cpp 25.60% <22.98%> (ø)
...ils/include/motion_utils/trajectory/trajectory.hpp 77.86% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@h-ohta h-ohta marked this pull request as ready for review August 22, 2022 02:13
@h-ohta h-ohta merged commit 23ec4bb into autowarefoundation:main Aug 23, 2022
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
* revert: readability-identifier-naming for pose history

This reverts commit 9278e71.

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* Revert "fix: build error"

This reverts commit 5e85599.

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* revert: readability-identifier-naming for pose history

This reverts commit 9278e71.

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* Revert "fix: build error"

This reverts commit 5e85599.

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
* revert: readability-identifier-naming for pose history

This reverts commit 9278e71.

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* Revert "fix: build error"

This reverts commit 5e85599.

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
yukke42 pushed a commit to tzhong518/autoware.universe that referenced this pull request Oct 14, 2022
…ation#1641)

* revert: readability-identifier-naming for pose history

This reverts commit 9278e71.

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* Revert "fix: build error"

This reverts commit 5e85599.

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
@h-ohta h-ohta deleted the revert/readability-identifier-naming branch October 17, 2022 05:45
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
* revert: readability-identifier-naming for pose history

This reverts commit 9278e71.

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* Revert "fix: build error"

This reverts commit 5e85599.

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants