-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: readability-identifier-naming for pose history #1641
Merged
h-ohta
merged 2 commits into
autowarefoundation:main
from
h-ohta:revert/readability-identifier-naming
Aug 23, 2022
Merged
revert: readability-identifier-naming for pose history #1641
h-ohta
merged 2 commits into
autowarefoundation:main
from
h-ohta:revert/readability-identifier-naming
Aug 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9278e71. Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
h-ohta
force-pushed
the
revert/readability-identifier-naming
branch
from
August 22, 2022 01:39
b91d58c
to
8b4ac95
Compare
h-ohta
changed the title
revert: readability-identifier-naming" for pose history
revert: readability-identifier-naming for pose history
Aug 22, 2022
This reverts commit 5e85599.
Codecov Report
@@ Coverage Diff @@
## main #1641 +/- ##
=======================================
Coverage 10.65% 10.65%
=======================================
Files 1109 1109
Lines 78524 78524
Branches 18520 18520
=======================================
Hits 8363 8363
Misses 61309 61309
Partials 8852 8852
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
isamu-takagi
approved these changes
Aug 23, 2022
yukke42
pushed a commit
to tzhong518/autoware.universe
that referenced
this pull request
Oct 14, 2022
…ation#1641) * revert: readability-identifier-naming for pose history This reverts commit 9278e71. Signed-off-by: h-ohta <hiroki.ota@tier4.jp> * Revert "fix: build error" This reverts commit 5e85599. Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9278e71 in #1608 .
Signed-off-by: h-ohta hiroki.ota@tier4.jp
Description
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.