Skip to content

Commit

Permalink
revert: readability-identifier-naming for pose history (tier4#1641)
Browse files Browse the repository at this point in the history
* revert: readability-identifier-naming for pose history

This reverts commit 9278e71.

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

* Revert "fix: build error"

This reverts commit 5e85599.

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>
  • Loading branch information
h-ohta authored and boyali committed Sep 28, 2022
1 parent 4b3be64 commit 2c296fd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ void PoseHistory::update(float wall_dt, float ros_dt)
if (!history_.empty()) {
lines_->clear();
if (property_line_view_->getBool()) {
update_lines();
updateLines();
}
}
}
Expand Down Expand Up @@ -92,18 +92,18 @@ void PoseHistory::processMessage(const geometry_msgs::msg::PoseStamped::ConstSha
history_.emplace_back(message);
last_stamp_ = message->header.stamp;

update_history();
updateHistory();
}

void PoseHistory::update_history()
void PoseHistory::updateHistory()
{
const auto buffer_size = static_cast<size_t>(property_buffer_size_->getInt());
while (buffer_size < history_.size()) {
history_.pop_front();
}
}

void PoseHistory::update_lines()
void PoseHistory::updateLines()
{
Ogre::ColourValue color = rviz_common::properties::qtToOgre(property_line_color_->getColor());
color.a = property_line_alpha_->getFloat();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ class PoseHistory : public rviz_common::MessageFilterDisplay<geometry_msgs::msg:
void subscribe() override;
void unsubscribe() override;
void processMessage(const geometry_msgs::msg::PoseStamped::ConstSharedPtr message) override;
void update_history();
void update_lines();
void updateHistory();
void updateLines();

std::string target_frame_;
std::deque<geometry_msgs::msg::PoseStamped::ConstSharedPtr> history_;
Expand Down

0 comments on commit 2c296fd

Please sign in to comment.