Repository navigation
chore(lighting): remove committed render evidence - #127
Merged
Merged
Conversation
Member
Author
|
Deep review is complete at
Interactive runtime verification is not applicable because no archetype, authored map, light behavior, or packaged runtime payload changed. Reproduce with the exact validation commands in the PR body; |
zoeyrose
marked this pull request as ready for review
August 11, 2026 16:49
This was referenced Aug 11, 2026
This was referenced Aug 11, 2026
zoeyrose
added a commit
that referenced
this pull request
Aug 11, 2026
## Summary - deliver an Incuna-specific starter property on Classic `1.x` instead of granting access to Strakewood apartments - add a 24×24 beach nook with a deliberately tiny 12-tile living area, one chest, coastal dressing, and a two-part hammock that teaches and acts as the save bed - grant the sole Incuna tier exactly once, preserve its entitlement and stored contents, gate the portal by ownership, and advance the tutorial only after using the hammock - preserve the apartment runtime collection changes and the exact binding, owner-gating, idempotency, persistence, map-reload, compatibility, and hammock-vocabulary tests - add two newly generated authored gameplay images, `hammock_a.101.png` and `hammock_b.101.png`, with explicit Zoey Rose / GPLv2 attribution and an OpenAI image-generation provenance note on each entry in the adjacent `LICENSE` Linked issue: #105. Canonical main PR: #111. ## Authored media and semantic lighting policy The hammock PNGs are intentional source assets used by gameplay, not generated lighting evidence. Their adjacent license enumerates both files directly. The semantic-only policy from #126 and merged PR #127 removes lighting contact sheets, their manifest, the proof scene, and capture-only tooling; it does not remove or prohibit authored gameplay art. This reconciliation keeps the apartment's schema-v5 semantic map digest but performs no light-source PNG or manifest refresh. No light-source evidence or capture-only path is tracked by this head. ## Coordinates - base: `1.x@b342d56` - head: `d67ffd281030b9b7a8bc4c9ea3002b5e4592a11c` - branch: `feat/105-incuna-apartment-1x` - worktree: `/workspaces/atrinik/workspace/worktrees/content-1x/issue-105-apartment-1x` ## Validation - `python3 arch/license_check.py --text-only --directory=arch/outdoor/hammock` — 2 licensed, 0 unlicensed; no invalid file/directory entry - `python3 tools/world_content_audit.py lights --check` — 97 archetypes, 4 artifacts, 11,393 instances across 625 maps; 5,579 explicit colors, 5,915 intentional neutral, zero unreviewed - `python3 tools/validate.py` — 128 tests passed; lossless core validated 1,355 archetypes and 3,651 maps; schema, catalog, contracts, syntax prototypes, resource collection, and both release archives passed - content catalog — 8,105 definitions and 68,595 references - `git ls-tree -r --name-only HEAD -- maps/light-source-evidence tools/light-source-review tools/light_review_evidence.py tools/tests/test_light_review_evidence.py` — no paths - `git diff --check` ## Manual verification handoff Use only the dedicated `issue-105-apartments` profile with a fresh scenario and unique topology/port. Play through Sam's Incuna handoff, speak to Elara, claim and enter the beach nook, store an item in its sole chest, use the hammock, exit/re-enter, and relog. Confirm the priest objective, entitlement, return point, and stored item persist; repeat steward and portal interactions to confirm the grant remains idempotent and does not unlock another region's housing. Stop the exact topology with `./atrinik down NAME` before resetting its scenario. No cleanup apply is required.
29 tasks done
zoeyrose
added a commit
that referenced
this pull request
Aug 11, 2026
## Summary - make `brazier_lit`, `fire_cauld.131`, `fireplace_left`, and `fireplace_right` emit reviewed `ff6030` firelight from their visible roots - preserve intentional radius-2 through radius-9 compositions while removing all 43 redundant same-tile neutral helper sources - retain and explicitly review the art-aligned Asteria amber-sconce/cauldron co-location - reconcile the branch to the current `1.x` tip as exactly 3 authored archetype files, 20 authored maps, and the schema-v5 semantic ledger Linked issue: #91. Canonical `main` companion: #129. ## Prerequisite and review-policy status - the `main` lighting prerequisite in #66 is complete through merged PR #124 - #126 is complete through merged PR #127; committed renderer captures and capture bindings remain retired - diagnostic rendering may be used only under ignored `build/` or deployment output and is not a merge or release gate - the apartment scenario remains maintainer-attested, and its newer `world_4_85` semantic-ledger record is preserved exactly The effective diff contains no evidence PNG, capture manifest, proof scene, capture tooling/test, capture-bound `views`/`evidence_focus` field, or render-binding documentation. ## Coordinates - base: `1.x@3a47443` - head: `9312f02ef0884612d7bf4ed8d785cd48fc2b11a9` - remote branch: `feat/91-firelight-fixtures-1x` - local reconciliation worktree: `/workspaces/atrinik/workspace/worktrees/content-1x/pr115-current` ## Validation - `python3 tools/world_content_audit.py lights --check` — 101 archetypes, 4 artifacts, 11,444 instances across 632 maps; 5,677 explicit colors, 5,872 intentional neutral, zero unreviewed - `python3 tools/validate.py` — 129 tests passed; lossless core validated 1,355 archetypes and 3,651 maps; schema, catalog, contracts, syntax prototypes, resource collection, and both `1.8.2` release archives passed - content catalog — 8,105 definitions and 68,588 references - effective branch diff — 3 archetype files, 20 authored maps, and `maps/light-source-review.json` - focused diff audit — all 43 redundant helpers transferred or removed, 18 intentional map-local radii preserved, and four root defaults added - prohibited-path/field audit — no retired evidence or capture paths and no `views`/`evidence_focus` fields - `git diff --check` ## Review outcome Two leaf review passes and a cumulative program review found no actionable findings. The visible fixture roots own the firelight, existing larger and smaller map-local footprints remain deliberate, multipart children and off variants remain dark, and the reviewed Asteria co-location remains represented in the semantic ledger. The branch has one commit directly atop the current `1.x` tip.
zoeyrose
added a commit
that referenced
this pull request
Aug 11, 2026
## Summary - move Rockforge City's unique dwarven teleporter lighting onto the visible multipart root - replace all nine neutral helpers across the overlapping 3×3 base and 2×2 teleporter footprint with one map-local radius-9 `ffe060` focal source - retain independent wall and room lighting while preserving every non-light field - extend the cumulative schema-v5 semantic review without restoring committed renderer evidence Refs #99. This `1.x` companion intentionally does not close the issue. ## Acceptance result - the visible teleporter root at `(6,6)` is the sole emitter on the composed-machine footprint - all nine `light9` helpers are removed, including the five helpers beyond the four originally enumerated by #99 - one map-local `glow_radius 9` and `light_color ffe060` replace the stack; the shared `dwarven_teleporter` archetype remains non-emitting - teleport behavior, destination, animation, direction, multipart structure, obstruction, coordinates, and non-light fields are unchanged - independent wall and room illumination remains separate - the navigation rationale preserves the cumulative #91/#102 review and adds the Rockforge result - the map record and semantic digest are refreshed only for `rockforge_a_0301` ## Current inventory - 101 reviewed archetypes and 4 reviewed artifacts - 11,436 effective light instances across 632 maps - 5,727 explicit colors and 5,814 intentional neutral emitters - zero unreviewed emitters ## Evidence policy - #126/#127 supersede the issue's former committed-capture requirements - no `maps/light-source-evidence/**`, manifest, proof scene, capture tooling/test, or capture-bound `views`/`evidence_focus` field is restored - optional smooth/discrete diagnostics remain untracked under ignored `build/` or deployment-owned output ## Coordinates - base: `1.x@7575b43` - head: `1f6d9e3c4599cbd92b87452164177f62d70bbfb3` - commits: exactly one - changed paths: exactly two — `maps/light-source-review.json` and `maps/shattered_islands/strakewood_island/rockforge/rockforge_a_0301` ## Validation - `python3 tools/world_content_audit.py lights --check` — 101 archetypes, 4 artifacts, 11,436 instances across 632 maps; 5,727 explicit colors, 5,814 intentional neutral, zero unreviewed - `python3 tools/validate.py` — 129 tests plus lossless content, schema, catalog, contracts, syntax prototypes, licensing, runtime collection, and both 1.8.2 archives pass - `git diff --check` - `jq empty maps/light-source-review.json` - `git ls-files 'maps/light-source-evidence/*'` — empty - focused diff audit — exactly nine `light9` removals, one map-local radius-9 addition, and one `ffe060` addition - the authored map result matches the previously reviewed PR #117 map byte-for-byte ## Merge order This is the first merge for #99. Squash-merge this `1.x` PR before creating and validating the canonical `main` companion; do not advance to #98 / PR #118 first.
zoeyrose
added a commit
that referenced
this pull request
Aug 11, 2026
## Summary - give `pool_acid` a restrained radius-1 `ff60c0` glow and `pool_poison` a radius-1 `40ff60` glow - transfer seven co-located neutral helpers to their existing pool instances, preserving two radius-3 and five radius-7 compositions without doubled sources - keep ordinary, blood, murky, water, and old pools non-emitting while preserving every non-light field - extend the cumulative schema-v5 semantic review without restoring committed renderer evidence or capture tooling Refs #98. This `1.x` companion intentionally does not close the issue. ## Acceptance result - all ten toxic-pool placements across seven maps have reviewed effective radii, colors, dispositions, rationales, and current semantic digests - the three previously unlit poison pools use the archetype's minimal radius-1 glow - the seven transferred compositions retain their exact footprints: two radius 3 and five radius 7 - exactly two `light3` and five `light7` helpers are removed; no doubled source remains - only `pool_acid` and `pool_poison` gain archetype light fields; other pool variants remain unchanged - type 79, art, placement, blocking/traversability, and other gameplay fields are preserved - the combined Asteria semantic digest was recalculated against merged #91 fixture ownership rather than copying the stale pre-#91 digest - cumulative #91/#102/#99 ledger semantics remain intact ## Current inventory - 103 reviewed archetypes and 4 reviewed artifacts - 11,439 effective light instances across 632 maps - 5,739 explicit colors and 5,807 intentional neutral emitters - zero unreviewed emitters ## Evidence policy - #126/#127 supersede the issue's former committed-capture requirements - no `maps/light-source-evidence/**`, manifest, proof scene, capture tooling/test, or capture-bound `views`/`evidence_focus` field is restored - optional smooth/discrete diagnostics remain untracked under ignored `build/` or deployment-owned output ## Coordinates - base: `1.x@941a2e1` - head: `b6e0e69c7f25157fa29c03e7a592f5824a4bc1c3` - commits: exactly one - changed paths: exactly six — one archetype file, four maps, and `maps/light-source-review.json` ## Validation - `python3 tools/world_content_audit.py lights --check` — 103 archetypes, 4 artifacts, 11,439 instances across 632 maps; 5,739 explicit colors, 5,807 intentional neutral, zero unreviewed - `python3 tools/validate.py` — 129 tests plus lossless content, schema, catalog, contracts, syntax prototypes, licensing, runtime collection, and both 1.8.2 archives pass - `git diff --check` - `jq empty maps/light-source-review.json` - `git ls-files 'maps/light-source-evidence/*'` — empty - focused diff audit — two radius-1 archetype defaults, two radius-3 and five radius-7 transfers, and exactly seven helper removals - all five non-ledger authored paths match the previously reviewed PR #118 result byte-for-byte ## Merge order This is the first merge for #98. Squash-merge this `1.x` PR before creating and validating the canonical `main` companion; do not advance to #95 / PR #119 first.
|
🎉 This PR is included in version 1.8.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.xRelates to #126. This sole
1.xPR intentionally has no closing keyword; the issue remains open for manual closure after merge.Release-line assessment
mainis an evidence-backed no-op atfde585e2dce52915704fa49608c07e8889f77bf5:git ls-files 'maps/light-source-evidence/*.png'returns no paths, and merged PR #124 already omitted the Classic capture manifest, proof scene, capture tooling, and screenshots while retaining the semantic ledger. The remaining artifact surface was Classic-only on1.x, so no syntheticmainchange is needed.Coordinates
1.xatbf460d92ce8e42cb169cdff57c99638df2fd4d95chore/126-remove-light-evidence-1xatdd4716577c22f9a5e4abef15327d7edc14f57a91/workspaces/atrinik/workspace/worktrees/content-1x/issue-126-light-evidence-1xdd4716577 chore(lighting): retire committed render evidenceValidation
python3 tools/world_content_audit.py lights --check— 97 archetypes, 4 artifacts, 11,393 map instances across 625 maps; 5,579 explicit colors, 5,915 intentional neutral, zero unreviewedpython3 tools/validate.py— 119 tests plus lossless core, semantic light audit, schema, catalog, contracts, authored syntax, resource collection, and source/runtime release archives passedpython3 -m compileall -q toolsgit diff --checkgit ls-files 'maps/light-source-evidence/*.png'— no paths on bothmainand this1.xheadVerification and runtime applicability
Interactive runtime verification is not applicable: this change removes generated review artifacts and capture-only tooling without modifying any archetype, map, light radius/color, activation behavior, or packaged runtime input. Verify the final head with:
python3 tools/world_content_audit.py lights --check python3 tools/validate.py git diff --check git ls-files 'maps/light-source-evidence/*.png'The last command must print nothing. Optional future imagery belongs below ignored
build/or pipeline-owned output under content #4, content #125, and atrinik/website#34; it is not a merge or release prerequisite. Keep this worktree and its local review report while the PR is open. Any later cleanup is a separate preview-first request beginning with./atrinik cleanup --dry-run --json.