Skip to content

feat(lighting): merge colored light content into main #66

Description

@zoeyrose

Target branch: main. This tracks carrying the Classic-line colored-content work from #64 and #65 into the main content line.

Approach

The relevant authored content remains largely shared between 1.x and main, so this should primarily be a targeted merge/port rather than an independent redesign:

Do not merge the entire 1.x branch into main. The release lines have diverged in metadata, generated contracts, tooling, and release policy; the integration should contain only the colored-light field and authored-content changes plus necessary main-specific resolutions.

Scope from #64

  • Add the exact six-digit object.light_color field to the authoritative main-line authored schema with neutral-white absent/default behavior.
  • Regenerate the field documentation, metadata, IDs, logical-document schema, and editor projection from the authoritative source.
  • Carry the representative warm/green torches and red/blue forcefield colors into their corresponding main-line archetypes.
  • Port the relevant schema, validation, catalog, and round-trip coverage, adapting it only where main's contracts differ.
  • Preserve the historical benchmark/provenance correction from the final feat(lighting): author colored light sources #64 change set rather than relabeling previously captured evidence.

Scope from #65

  • Carry each reviewed visible-source and map-specific/invisible-light color batch into main as the 1.x audit progresses.
  • Keep a deterministic semantic inventory of all effective nonzero emitters, resolving inherited archetype values and map overrides rather than searching only for literal glow_radius lines.
  • Preserve each contextual review decision: explicit RGB color, intentionally neutral white, or a documented unresolved mapper/art-direction question.
  • Review conflicts against the actual main-line map/archetype version; do not blindly overwrite a source that has materially diverged.
  • Avoid unrelated radius, placement, obstruction, or gameplay-visibility changes unless separately justified.

Acceptance criteria

  • A focused main PR carries the complete final feat(lighting): author colored light sources #64 field/schema/example change set with history and attribution preserved where practical.
  • The main-line diff contains no unrelated 1.x release metadata, branch-only generated artifacts, or wholesale branch-merge churn.
  • object.light_color has the same exact RGB24 and neutral-default semantics on both release lines, with documented main-specific differences only where required.
  • Corresponding archetypes and maps that remain shared receive the same reviewed colors; genuine main-line divergences are resolved and documented rather than overwritten.
  • Subsequent chore(maps): audit authored light-source colors #65 audit batches are mirrored into main through focused linked PRs or commits until the main-line semantic inventory has no unreviewed emitters.
  • Invisible/map-local lights retain their human contextual review; they are not mass-colored solely by name or radius during the merge.
  • Main-line schema generation, catalog/content-core tests, python3 tools/validate.py, and git diff --check pass after conflict resolution.
  • The final PR links feat(lighting): author colored light sources #64 and chore(maps): audit authored light-source colors #65 and records the exact commits/batches carried into main.

Runtime rendering support in the replacement stack may land separately; this issue owns the main-line content/schema integration and must link the relevant consumer work before claiming the colors are visually active there.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Fields

Priority

None yet

Start date

None yet

Target date

None yet

Effort

None yet

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions