Repository navigation
fix(items): give power crystals restrained light - #119
Merged
Merged
Conversation
zoeyrose
marked this pull request as ready for review
August 11, 2026 11:07
This was referenced Aug 11, 2026
zoeyrose
added a commit
that referenced
this pull request
Aug 11, 2026
## Summary - give `pool_acid` a restrained radius-1 `ff60c0` glow and `pool_poison` a radius-1 `40ff60` glow - transfer seven co-located neutral helpers to their existing pool instances, preserving two radius-3 and five radius-7 compositions without doubled sources - keep ordinary, blood, murky, water, and old pools non-emitting while preserving every non-light field - extend the cumulative schema-v5 semantic review without restoring committed renderer evidence or capture tooling Refs #98. This `1.x` companion intentionally does not close the issue. ## Acceptance result - all ten toxic-pool placements across seven maps have reviewed effective radii, colors, dispositions, rationales, and current semantic digests - the three previously unlit poison pools use the archetype's minimal radius-1 glow - the seven transferred compositions retain their exact footprints: two radius 3 and five radius 7 - exactly two `light3` and five `light7` helpers are removed; no doubled source remains - only `pool_acid` and `pool_poison` gain archetype light fields; other pool variants remain unchanged - type 79, art, placement, blocking/traversability, and other gameplay fields are preserved - the combined Asteria semantic digest was recalculated against merged #91 fixture ownership rather than copying the stale pre-#91 digest - cumulative #91/#102/#99 ledger semantics remain intact ## Current inventory - 103 reviewed archetypes and 4 reviewed artifacts - 11,439 effective light instances across 632 maps - 5,739 explicit colors and 5,807 intentional neutral emitters - zero unreviewed emitters ## Evidence policy - #126/#127 supersede the issue's former committed-capture requirements - no `maps/light-source-evidence/**`, manifest, proof scene, capture tooling/test, or capture-bound `views`/`evidence_focus` field is restored - optional smooth/discrete diagnostics remain untracked under ignored `build/` or deployment-owned output ## Coordinates - base: `1.x@941a2e1` - head: `b6e0e69c7f25157fa29c03e7a592f5824a4bc1c3` - commits: exactly one - changed paths: exactly six — one archetype file, four maps, and `maps/light-source-review.json` ## Validation - `python3 tools/world_content_audit.py lights --check` — 103 archetypes, 4 artifacts, 11,439 instances across 632 maps; 5,739 explicit colors, 5,807 intentional neutral, zero unreviewed - `python3 tools/validate.py` — 129 tests plus lossless content, schema, catalog, contracts, syntax prototypes, licensing, runtime collection, and both 1.8.2 archives pass - `git diff --check` - `jq empty maps/light-source-review.json` - `git ls-files 'maps/light-source-evidence/*'` — empty - focused diff audit — two radius-1 archetype defaults, two radius-3 and five radius-7 transfers, and exactly seven helper removals - all five non-ledger authored paths match the previously reviewed PR #118 result byte-for-byte ## Merge order This is the first merge for #98. Squash-merge this `1.x` PR before creating and validating the canonical `main` companion; do not advance to #95 / PR #119 first.
zoeyrose
added a commit
that referenced
this pull request
Aug 11, 2026
## Summary - give `pool_acid` a restrained radius-1 `ff60c0` glow and `pool_poison` a radius-1 `40ff60` glow - transfer seven co-located neutral helpers to their existing pool instances, preserving two radius-3 and five radius-7 compositions without doubled sources - keep ordinary, blood, murky, water, and old pools non-emitting while preserving every non-light field - extend the cumulative `main`-native schema-v5 semantic review while retaining line-specific runtime metadata Closes #98. This is the canonical `main` companion to merged `1.x` PR #118 (`4711f1e754506d4786e12116d61bec7ea9f0da56`). ## Acceptance result - all ten toxic-pool placements across seven maps have reviewed effective radii, colors, dispositions, rationales, and current semantic digests - the three previously unlit poison pools use the archetype's minimal radius-1 glow - the seven transferred compositions retain their exact footprints: two radius 3 and five radius 7 - exactly two `light3` and five `light7` helpers are removed; no doubled source remains - only `pool_acid` and `pool_poison` gain archetype light fields; other pool variants remain unchanged - type 79, art, placement, blocking/traversability, and other gameplay fields are preserved - all five non-ledger authored files match merged `1.x` byte-for-byte - six of seven map semantic digests match `1.x`; `old_outpost_a_0203` uses the correct `main`-native digest because another effective source already differs there - the `main` ledger preserves cumulative #91/#102/#99 semantics, line-native runtime/source metadata, and existing `classic_views` ## Current inventory - 103 reviewed archetypes and 4 reviewed artifacts - 11,439 effective light instances across 632 maps - 5,739 explicit colors and 5,807 intentional neutral emitters - zero unreviewed emitters ## Evidence policy - no `maps/light-source-evidence/**`, manifest, proof scene, capture tooling/test, or capture-bound `views`/`evidence_focus` field is restored - optional renderer diagnostics remain untracked under ignored `build/` or deployment-owned output - replacement `main` validates authored and semantic contracts without claiming integrated Classic runtime rendering ## Coordinates - base: `main@b0985c0` - head: `10e64c7fa26ef93a8d637fee096dfc4ed51e93da` - commits: exactly one - changed paths: exactly six — one archetype file, four maps, and `maps/light-source-review.json` ## Validation - `python3 tools/world_content_audit.py lights --check` — 103 archetypes, 4 artifacts, 11,439 instances across 632 maps; 5,739 explicit colors, 5,807 intentional neutral, zero unreviewed - `python3 tools/validate.py` — 129 tests plus lossless content, schema, catalog, contracts, syntax prototypes, licensing, and runtime collection pass - `git diff --check` - `jq empty maps/light-source-review.json` - `git ls-files 'maps/light-source-evidence/*'` — empty - focused diff audit — two radius-1 archetype defaults, two radius-3 and five radius-7 transfers, and exactly seven helper removals - cross-line authored comparison — all five non-ledger paths match merged `1.x` byte-for-byte ## Merge order Merge only after #118, which is already squash-merged to `1.x` as `4711f1e754506d4786e12116d61bec7ea9f0da56`. This PR is the second and final merge for #98 before proceeding to #95 / PR #119.
zoeyrose
force-pushed
the
feat/95-power-crystal-light-1x
branch
from
August 11, 2026 23:40
21f9278 to
f7757a3
Compare
10 tasks
|
🎉 This PR is included in version 1.8.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
zoeyrose
added a commit
that referenced
this pull request
Aug 12, 2026
## Summary - give the base power crystal a restrained radius-1 `fff0c0` glow inherited by all six artifact variants - preserve the immutable Classic lifecycle record as source-behavior provenance without claiming replacement-runtime execution - extend the cumulative `main` semantic ledger while retaining replacement-specific guidance and existing `classic_views` Closes #95. This is the canonical `main` companion to merged `1.x` PR #119 (`371845c879955cb6910e2ac86b8ecf7ce7fca65e`). ## Acceptance result - `power_crystal` gains only `glow_radius 1` and `light_color fff0c0` - `mana_crystal_25`, `mana_crystal_50`, `mana_crystal_100`, and `gandyld_crystal_1` through `_3` inherit one non-amplifying radius-1 source - the Marigold display remains composed beside stronger neutral helper lighting and the currently non-emitting crystal ball - charge capacity, artifact identity, quest upgrades, merchant behavior, value, weight, face, animation, and every other gameplay field remain unchanged - the archetype and 72-line lifecycle record match merged `1.x` byte-for-byte - all seven source/artifact semantic digests and all four affected map digests match merged `1.x` - the audit guide remains intentionally `main`-native and preserves the replacement runtime boundary ## Current inventory - 104 reviewed archetypes and 10 reviewed artifacts - 11,445 effective light instances across 632 maps - 5,752 explicit colors and 5,807 intentional neutral emitters - zero unreviewed emitters ## Evidence policy - no `maps/light-source-evidence/**`, manifest, proof scene, capture tooling/test, or capture-bound `views`/`evidence_focus` field is restored - existing `classic_views` remain unchanged as line-native historical provenance - optional renderer diagnostics remain generated only under ignored `build/` or deployment-owned output - replacement validation proves authored/schema/catalog/semantic compatibility without claiming integrated runtime rendering ## Coordinates - base: `main@a14e70c` - head: `9d2f579b963b9726a7f3b62d9628fe09e8ea34cb` - commits: exactly one - changed paths: exactly four — `power_crystal.arc`, two review documents, and `maps/light-source-review.json` ## Validation - `python3 tools/world_content_audit.py lights --check` — passed with the inventory above - `python3 tools/validate.py` — 129 tests plus lossless content, schema, catalog, contracts, syntax prototypes, licensing, and runtime collection passed - `git diff --check` - `jq empty maps/light-source-review.json` - `git ls-files 'maps/light-source-evidence/*'` — empty - focused whole-diff review — exactly two gameplay-field additions, no map edits, and no changes to `views`, `evidence_focus`, or `classic_views` - cross-line comparison — archetype, lifecycle record, seven source/artifact digests, and four affected map digests match merged `1.x` ## Merge order Merge only after PR #119, which is already squash-merged to `1.x` as `371845c879955cb6910e2ac86b8ecf7ce7fca65e`. This is the second and final merge for #95 before proceeding to #96 / PR #120.
zoeyrose
added a commit
that referenced
this pull request
Aug 23, 2026
## Summary - give `pool_acid` a restrained radius-1 `ff60c0` glow and `pool_poison` a radius-1 `40ff60` glow - transfer seven co-located neutral helpers to their existing pool instances, preserving two radius-3 and five radius-7 compositions without doubled sources - keep ordinary, blood, murky, water, and old pools non-emitting while preserving every non-light field - extend the cumulative `main`-native schema-v5 semantic review while retaining line-specific runtime metadata Closes #98. This is the canonical `main` companion to merged `1.x` PR #118 (`bc220bda7de8cf73f05644daf344d2ac75a8a687`). ## Acceptance result - all ten toxic-pool placements across seven maps have reviewed effective radii, colors, dispositions, rationales, and current semantic digests - the three previously unlit poison pools use the archetype's minimal radius-1 glow - the seven transferred compositions retain their exact footprints: two radius 3 and five radius 7 - exactly two `light3` and five `light7` helpers are removed; no doubled source remains - only `pool_acid` and `pool_poison` gain archetype light fields; other pool variants remain unchanged - type 79, art, placement, blocking/traversability, and other gameplay fields are preserved - all five non-ledger authored files match merged `1.x` byte-for-byte - six of seven map semantic digests match `1.x`; `old_outpost_a_0203` uses the correct `main`-native digest because another effective source already differs there - the `main` ledger preserves cumulative #91/#102/#99 semantics, line-native runtime/source metadata, and existing `classic_views` ## Current inventory - 103 reviewed archetypes and 4 reviewed artifacts - 11,439 effective light instances across 632 maps - 5,739 explicit colors and 5,807 intentional neutral emitters - zero unreviewed emitters ## Evidence policy - no `maps/light-source-evidence/**`, manifest, proof scene, capture tooling/test, or capture-bound `views`/`evidence_focus` field is restored - optional renderer diagnostics remain untracked under ignored `build/` or deployment-owned output - replacement `main` validates authored and semantic contracts without claiming integrated Classic runtime rendering ## Coordinates - base: `main@c13d40c5c182246b951af2262b908c310bfd311d` - head: `d562ae58fa5d899be47a284e64a8e6664de2f8ae` - commits: exactly one - changed paths: exactly six — one archetype file, four maps, and `maps/light-source-review.json` ## Validation - `python3 tools/world_content_audit.py lights --check` — 103 archetypes, 4 artifacts, 11,439 instances across 632 maps; 5,739 explicit colors, 5,807 intentional neutral, zero unreviewed - `python3 tools/validate.py` — 129 tests plus lossless content, schema, catalog, contracts, syntax prototypes, licensing, and runtime collection pass - `git diff --check` - `jq empty maps/light-source-review.json` - `git ls-files 'maps/light-source-evidence/*'` — empty - focused diff audit — two radius-1 archetype defaults, two radius-3 and five radius-7 transfers, and exactly seven helper removals - cross-line authored comparison — all five non-ledger paths match merged `1.x` byte-for-byte ## Merge order Merge only after #118, which is already squash-merged to `1.x` as `bc220bda7de8cf73f05644daf344d2ac75a8a687`. This PR is the second and final merge for #98 before proceeding to #95 / PR #119.
zoeyrose
added a commit
that referenced
this pull request
Aug 23, 2026
## Summary - give the base power crystal a restrained radius-1 `fff0c0` glow inherited by all six artifact variants - preserve the immutable Classic lifecycle record as source-behavior provenance without claiming replacement-runtime execution - extend the cumulative `main` semantic ledger while retaining replacement-specific guidance and existing `classic_views` Closes #95. This is the canonical `main` companion to merged `1.x` PR #119 (`c1f3e01d3661267732e1b2c57a2e9a53aa0f3167`). ## Acceptance result - `power_crystal` gains only `glow_radius 1` and `light_color fff0c0` - `mana_crystal_25`, `mana_crystal_50`, `mana_crystal_100`, and `gandyld_crystal_1` through `_3` inherit one non-amplifying radius-1 source - the Marigold display remains composed beside stronger neutral helper lighting and the currently non-emitting crystal ball - charge capacity, artifact identity, quest upgrades, merchant behavior, value, weight, face, animation, and every other gameplay field remain unchanged - the archetype and 72-line lifecycle record match merged `1.x` byte-for-byte - all seven source/artifact semantic digests and all four affected map digests match merged `1.x` - the audit guide remains intentionally `main`-native and preserves the replacement runtime boundary ## Current inventory - 104 reviewed archetypes and 10 reviewed artifacts - 11,445 effective light instances across 632 maps - 5,752 explicit colors and 5,807 intentional neutral emitters - zero unreviewed emitters ## Evidence policy - no `maps/light-source-evidence/**`, manifest, proof scene, capture tooling/test, or capture-bound `views`/`evidence_focus` field is restored - existing `classic_views` remain unchanged as line-native historical provenance - optional renderer diagnostics remain generated only under ignored `build/` or deployment-owned output - replacement validation proves authored/schema/catalog/semantic compatibility without claiming integrated runtime rendering ## Coordinates - base: `main@07fd8dd216fb40e08a9dcd4174d5658a5264a845` - head: `09d2688f71afaa0cd0b791c6e8f5e6f7f7fbca7f` - commits: exactly one - changed paths: exactly four — `power_crystal.arc`, two review documents, and `maps/light-source-review.json` ## Validation - `python3 tools/world_content_audit.py lights --check` — passed with the inventory above - `python3 tools/validate.py` — 129 tests plus lossless content, schema, catalog, contracts, syntax prototypes, licensing, and runtime collection passed - `git diff --check` - `jq empty maps/light-source-review.json` - `git ls-files 'maps/light-source-evidence/*'` — empty - focused whole-diff review — exactly two gameplay-field additions, no map edits, and no changes to `views`, `evidence_focus`, or `classic_views` - cross-line comparison — archetype, lifecycle record, seven source/artifact digests, and four affected map digests match merged `1.x` ## Merge order Merge only after PR #119, which is already squash-merged to `1.x` as `c1f3e01d3661267732e1b2c57a2e9a53aa0f3167`. This is the second and final merge for #95 before proceeding to #96 / PR #120.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fff0c0glow inherited by all six artifact variants1.xsemantic ledger while preserving all earlier lighting-pair decisions and release-control workRelated issue: #95. This is the separate Classic-compatible
1.xdelivery and is intentionally non-closing. Its canonicalmaincompanion will be built only after this PR is squash-merged.Reconciliation
1.x@9279e0460179df8322d30e05f2c748dd2e3d2272f7757a31ef5c3cded7e261ae82d588dd82a59e48fix(items)because the live1.xpolicy accepts patch releases onlyAcceptance result
power_crystalgains onlyglow_radius 1andlight_color fff0c0mana_crystal_25,mana_crystal_50,mana_crystal_100, andgandyld_crystal_1through_3inherit one non-amplifying radius-1 sourcetypes.light_applycases remain bound to their immutable runtime inputsCurrent inventory
Evidence policy
maps/light-source-evidence/**, manifest, proof scene, capture tooling/test, or capture-boundviews/evidence_focusfield is restoredbuild/or deployment-owned outputValidation
python3 tools/world_content_audit.py lights --check— passed with the inventory abovepython3 tools/validate.py— 131 tests plus lossless content, schema, catalog, contracts, syntax prototypes, licensing, runtime collection, and both release archives passedpython3 tools/check_pr_title.py --base 1.x 'fix(items): give power crystals restrained light'git diff --checkjq empty maps/light-source-review.jsonMerge order
This is the first half of the #95 release-line pair. Squash-merge this PR first. Then re-query live
1.xandmaintips before constructing and validating the canonicalmaincompanion. Do not manually close #95 at this gate.