Repository navigation
feat(items): give power crystals restrained light - #167
Merged
Merged
Conversation
This was referenced Aug 12, 2026
|
🎉 This PR is included in version 2.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
8 tasks done
zoeyrose
added a commit
that referenced
this pull request
Aug 23, 2026
## Summary - give the base power crystal a restrained radius-1 `fff0c0` glow inherited by all six artifact variants - preserve the immutable Classic lifecycle record as source-behavior provenance without claiming replacement-runtime execution - extend the cumulative `main` semantic ledger while retaining replacement-specific guidance and existing `classic_views` Closes #95. This is the canonical `main` companion to merged `1.x` PR #119 (`c1f3e01d3661267732e1b2c57a2e9a53aa0f3167`). ## Acceptance result - `power_crystal` gains only `glow_radius 1` and `light_color fff0c0` - `mana_crystal_25`, `mana_crystal_50`, `mana_crystal_100`, and `gandyld_crystal_1` through `_3` inherit one non-amplifying radius-1 source - the Marigold display remains composed beside stronger neutral helper lighting and the currently non-emitting crystal ball - charge capacity, artifact identity, quest upgrades, merchant behavior, value, weight, face, animation, and every other gameplay field remain unchanged - the archetype and 72-line lifecycle record match merged `1.x` byte-for-byte - all seven source/artifact semantic digests and all four affected map digests match merged `1.x` - the audit guide remains intentionally `main`-native and preserves the replacement runtime boundary ## Current inventory - 104 reviewed archetypes and 10 reviewed artifacts - 11,445 effective light instances across 632 maps - 5,752 explicit colors and 5,807 intentional neutral emitters - zero unreviewed emitters ## Evidence policy - no `maps/light-source-evidence/**`, manifest, proof scene, capture tooling/test, or capture-bound `views`/`evidence_focus` field is restored - existing `classic_views` remain unchanged as line-native historical provenance - optional renderer diagnostics remain generated only under ignored `build/` or deployment-owned output - replacement validation proves authored/schema/catalog/semantic compatibility without claiming integrated runtime rendering ## Coordinates - base: `main@07fd8dd216fb40e08a9dcd4174d5658a5264a845` - head: `09d2688f71afaa0cd0b791c6e8f5e6f7f7fbca7f` - commits: exactly one - changed paths: exactly four — `power_crystal.arc`, two review documents, and `maps/light-source-review.json` ## Validation - `python3 tools/world_content_audit.py lights --check` — passed with the inventory above - `python3 tools/validate.py` — 129 tests plus lossless content, schema, catalog, contracts, syntax prototypes, licensing, and runtime collection passed - `git diff --check` - `jq empty maps/light-source-review.json` - `git ls-files 'maps/light-source-evidence/*'` — empty - focused whole-diff review — exactly two gameplay-field additions, no map edits, and no changes to `views`, `evidence_focus`, or `classic_views` - cross-line comparison — archetype, lifecycle record, seven source/artifact digests, and four affected map digests match merged `1.x` ## Merge order Merge only after PR #119, which is already squash-merged to `1.x` as `c1f3e01d3661267732e1b2c57a2e9a53aa0f3167`. This is the second and final merge for #95 before proceeding to #96 / PR #120.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fff0c0glow inherited by all six artifact variantsmainsemantic ledger while retaining replacement-specific guidance and existingclassic_viewsCloses #95.
This is the canonical
maincompanion to merged1.xPR #119 (371845c879955cb6910e2ac86b8ecf7ce7fca65e).Acceptance result
power_crystalgains onlyglow_radius 1andlight_color fff0c0mana_crystal_25,mana_crystal_50,mana_crystal_100, andgandyld_crystal_1through_3inherit one non-amplifying radius-1 source1.xbyte-for-byte1.xmain-native and preserves the replacement runtime boundaryCurrent inventory
Evidence policy
maps/light-source-evidence/**, manifest, proof scene, capture tooling/test, or capture-boundviews/evidence_focusfield is restoredclassic_viewsremain unchanged as line-native historical provenancebuild/or deployment-owned outputCoordinates
main@a14e70cc83686723405196b70ff4fca18bc975e89d2f579b963b9726a7f3b62d9628fe09e8ea34cbpower_crystal.arc, two review documents, andmaps/light-source-review.jsonValidation
python3 tools/world_content_audit.py lights --check— passed with the inventory abovepython3 tools/validate.py— 129 tests plus lossless content, schema, catalog, contracts, syntax prototypes, licensing, and runtime collection passedgit diff --checkjq empty maps/light-source-review.jsongit ls-files 'maps/light-source-evidence/*'— emptyviews,evidence_focus, orclassic_views1.xMerge order
Merge only after PR #119, which is already squash-merged to
1.xas371845c879955cb6910e2ac86b8ecf7ce7fca65e. This is the second and final merge for #95 before proceeding to #96 / PR #120.