Repository navigation
feat(maps): transfer crystal light ownership - #116
Merged
Merged
Conversation
zoeyrose
marked this pull request as ready for review
August 11, 2026 08:54
This was referenced Aug 11, 2026
zoeyrose
force-pushed
the
feat/102-crystal-lights-1x
branch
from
August 11, 2026 21:24
94a5226 to
36d4bdc
Compare
zoeyrose
added a commit
that referenced
this pull request
Aug 11, 2026
## Summary - transfer all 49 co-located `light3`, `light5`, and `light7` helpers in Brynknot Abyss and eight Zechna Temple maps to their existing crystal objects - give nine stable crystal archetypes art-matched red, purple, blue, yellow, and soft-white color suppliers without adding archetype-level radii - preserve the exact radius-3/radius-5/radius-7 footprints, linked-map continuity, navigation contrast, and every non-light field - reconcile the shared Zechna scene and the `main`-native semantic ledger with merged fire-fixture ownership from #91 Closes #102. This is the canonical `main` companion to merged `1.x` PR #116 (`7575b438ae985bfa4a2347776a27c37368f5ee0a`). ## Acceptance result - 49 reviewed crystal emitters across exactly nine maps - colors: 24 red `ff3030`, 19 purple `a060ff`, 3 blue `60d0ff`, 1 yellow `ffe060`, and 2 soft-white `fff0c0` - radii: 32 radius-3, 13 radius-5, and 4 radius-7 placements - all 49 neutral helpers transferred or removed; no archetype-level `glow_radius` - the ten non-ledger authored paths are byte-identical to the merged `1.x` result - the shared `zechna_temple_0_0_-2` ledger record retains the combined red crystal pool and two orange-red braziers from #91 - 101 reviewed archetypes, 4 reviewed artifacts, 11,444 light instances across 632 maps, 5,726 explicit colors, 5,823 intentional neutral emitters, and zero unreviewed emitters - no retired evidence path, manifest, proof scene, capture tooling/test, or capture-bound `views`/`evidence_focus` field is restored - `main` runtime status and source-review metadata remain line-native; existing `classic_views` metadata is preserved unchanged ## Coordinates - base: `main@0d3f8eb` - head: `ab78f0f7e8311825e3f48e527110dec87c31e397` - changed paths: exactly 11 (one archetype file, nine maps, and `maps/light-source-review.json`) ## Validation - `python3 tools/world_content_audit.py lights --check` - `python3 tools/validate.py` — 129 tests passed; 3,561 canonical plural definitions complete - `git diff --check` - `jq empty maps/light-source-review.json` - `git ls-files 'maps/light-source-evidence/*'` — empty - focused transfer audit — 49 helpers removed and 49 map-local radii added with the declared color/radius distributions - cross-line authored comparison — all ten non-ledger paths match merged `1.x` byte-for-byte ## Merge order Merge only after #116, which is already squash-merged to `1.x` as `7575b438ae985bfa4a2347776a27c37368f5ee0a`. This PR is the second and final merge for #102 before proceeding to #99 / PR #117.
|
🎉 This PR is included in version 1.8.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
zoeyrose
added a commit
that referenced
this pull request
Aug 23, 2026
## Summary - transfer all 49 co-located `light3`, `light5`, and `light7` helpers in Brynknot Abyss and eight Zechna Temple maps to their existing crystal objects - give nine stable crystal archetypes art-matched red, purple, blue, yellow, and soft-white color suppliers without adding archetype-level radii - preserve the exact radius-3/radius-5/radius-7 footprints, linked-map continuity, navigation contrast, and every non-light field - reconcile the shared Zechna scene and the `main`-native semantic ledger with merged fire-fixture ownership from #91 Closes #102. This is the canonical `main` companion to merged `1.x` PR #116 (`6b4bf438f149ee9559f20e95c2c77aba3a25fe37`). ## Acceptance result - 49 reviewed crystal emitters across exactly nine maps - colors: 24 red `ff3030`, 19 purple `a060ff`, 3 blue `60d0ff`, 1 yellow `ffe060`, and 2 soft-white `fff0c0` - radii: 32 radius-3, 13 radius-5, and 4 radius-7 placements - all 49 neutral helpers transferred or removed; no archetype-level `glow_radius` - the ten non-ledger authored paths are byte-identical to the merged `1.x` result - the shared `zechna_temple_0_0_-2` ledger record retains the combined red crystal pool and two orange-red braziers from #91 - 101 reviewed archetypes, 4 reviewed artifacts, 11,444 light instances across 632 maps, 5,726 explicit colors, 5,823 intentional neutral emitters, and zero unreviewed emitters - no retired evidence path, manifest, proof scene, capture tooling/test, or capture-bound `views`/`evidence_focus` field is restored - `main` runtime status and source-review metadata remain line-native; existing `classic_views` metadata is preserved unchanged ## Coordinates - base: `main@505ccf945acfe77c014dbc82c05760d5a46de219` - head: `4114c1862e97ab1a7d852c127e12f7de8272d508` - changed paths: exactly 11 (one archetype file, nine maps, and `maps/light-source-review.json`) ## Validation - `python3 tools/world_content_audit.py lights --check` - `python3 tools/validate.py` — 129 tests passed; 3,561 canonical plural definitions complete - `git diff --check` - `jq empty maps/light-source-review.json` - `git ls-files 'maps/light-source-evidence/*'` — empty - focused transfer audit — 49 helpers removed and 49 map-local radii added with the declared color/radius distributions - cross-line authored comparison — all ten non-ledger paths match merged `1.x` byte-for-byte ## Merge order Merge only after #116, which is already squash-merged to `1.x` as `6b4bf438f149ee9559f20e95c2c77aba3a25fe37`. This PR is the second and final merge for #102 before proceeding to #99 / PR #117.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
light3,light5, andlight7helpers in Brynknot Abyss and eight Zechna Temple maps to the existing crystal objectsRelates to #102. This
1.xcompanion intentionally does not close the issue.Acceptance result
ff3030, 19 purplea060ff, 3 blue60d0ff, 1 yellowffe060, and 2 soft-whitefff0c0zechna_temple_1_0_-3remains the declared 15-source stress mapThe retained Classic review concludes that the dense Zechna composition and Brynknot checkerboard remain bounded and readable. The combined
zechna_temple_0_0_-2record now covers both its crystal-owned red pool and the two previously merged fixture-owned braziers.Evidence policy
No evidence bitmap, capture manifest, proof scene, capture tooling/test, or documentation-only path is changed. This diff adds no capture-bound
classic_views,views, orevidence_focusfield. Optional diagnostics remain ignored underbuild/or deployment output.Coordinates
1.x@d2387818a014536da84833d6f8179e9112b9f6c836d4bdc280e29a9dc01bf6824389d74077c51427feat/102-crystal-lights-1x/workspaces/atrinik/workspace/worktrees/content-1x/pr116-currentValidation
python3 tools/world_content_audit.py lights --check— 101 archetypes, 4 artifacts, 11,444 instances across 632 maps; 5,726 explicit colors, 5,823 intentional neutral, zero unreviewedpython3 tools/validate.py— 129 tests passed; lossless core validated 1,355 archetypes and 3,651 maps; schema, catalog, contracts, syntax prototypes, resource collection, and both1.8.2release archives passedmaps/light-source-review.jsongit diff --checkReview outcome
Two leaf review passes and a cumulative program review found and fixed the combined Zechna fire/crystal record, then found no remaining actionable findings. Coordinates, obstruction, encounters, exits, quests, static scenery, and every non-light field remain unchanged. After this maintainer merge, the program will re-query both live tips before reconciling the canonical
maincompanion.