fix: don't print help for non-validation errors. Fixes argoproj#14234

[jumpe1]

Fixes #14234

Motivation

The default behavior with Cobra is to print the help text for all errors, which can be tedious to scroll through.

Modifications

This changes the CLI to only print the help text for argument validation errors.
Here are the related PRs.
#13831

Verification

I reproduced the issue by applying the following manifest and intentionally causing a failure when accessing /apis/argoproj.io/v1alpha1/namespaces/{namespace}/workflowtaskresults.
I confirmed that the help log does not appear.

apiVersion: networking.k8s.io/v1
kind: NetworkPolicy
metadata:
  name: deny-to-api-server
spec:
  podSelector: {}
  policyTypes:
    - Egress
  egress:
    - to:
        - ipBlock:
            cidr: 172.22.0.1/32
      ports:
        - protocol: TCP
          port: 6443

Note

Some CI tests are failing, but this is likely caused by known flaky tests, as documented in #14120.

I have confirmed that the relevant tests for this change pass locally.
These CI failures are likely unrelated to the changes in this PR.

Documentation

[MasonM]

/retest

[MasonM]

Thanks for the fix! I'd like to understand the behavior you're seeing, so if you could provide some more details, that'd be very helpful: #14234 (comment)

[MasonM]

Thanks for the details in #14234 (comment)! I understand this now, and your fix looks right to me.

I think it's worth having a test for this, though it's slightly tricky. The best way I found to trigger this is to submit a workflow that has a serviceAccountName lacking sufficient permissions. That's really a scenario we should be testing anyway, so I went ahead and wrote a test for that (and refactored an existing test): MasonM@b1a2442

Here's commands to merge it into your branch:

git fetch git@github.com:MasonM/argo-workflows.git b1a24421678875dcbe10f77f3281a9def31e0597 
git merge b1a24421678875dcbe10f77f3281a9def31e0597   

though if you can think of a better way to test this, then feel free to do that instead.

[MasonM]

/retest

[jumpe1]

@MasonM
Thanks for adding the test.
Since this is my first contribution, I took some time to think about it, and I think your testing approach is the best.
I have merged your commit. Please review it.

[MasonM]

Good job!

[Joibel]

I appreciate the code reuse change in the test framework too, thank you.

[Joibel]

/cherry-pick release-3.6