fix: don't print help for non-validation errors. Fixes #13826 #13831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argoproj#13656 changed all CLI commands to use `RunE` instead of `Run` and [cobra validators](https://cobra.dev/#positional-and-custom-arguments). The default behavior with Cobra is to print the help text for all errors, which can be tedious to scroll through. This changes the CLI to only print the help text for argument validation errors, which should match the previous behavior. Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com>
Joibel
approved these changes
Oct 29, 2024
Member
Joibel
left a comment
Joibel
left a comment
There was a problem hiding this comment.
Looks good and works for me locally, thanks for fixing this quickly.
This was referenced Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13826
Motivation
#13656 changed all CLI commands to use
RunEinstead ofRunand to use Cobra validators for validating arguments. The default behavior with Cobra is to print the help text for all errors, which can be tedious to scroll through.Modifications
This changes the CLI to only print the help text for argument validation errors, which should match the previous behavior.
Verification