fix: bump deps for k8schain to fix ecr-login

[Joibel]

Speculatively fixes #13947

Motivation

Users of magically logged into ECR appears to have broken in 3.6. It's unclear if this is IRSA that's broken at this stage.

Modifications

Bump everything used by container_registry_index.go

go get  github.com/google/go-containerregistry/pkg/authn/k8schain 
go get github.com/awslabs/amazon-ecr-credential-helper/ecr-login
go get  github.com/google/go-containerregistry/pkg/v1/remote
go get  github.com/google/go-containerregistry/pkg/name
go mod tidy

Verification

Untested. This won't be merged unless someone verifies that it helps.

If you are interested in testing this please build your own image using make workflow-controller-image. I can build one for you, but you shouldn't take random images from a stranger on the internet really.

[tooptoop4]

need https://github.com/tektoncd/pipeline/pull/7921/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R143

[Joibel]

need https://github.com/tektoncd/pipeline/pull/7921/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R143

@tooptoop4 Have you verified this? We're not apparently pulling in github.com/aws/aws-sdk-go-v2 below 1.23.0.

[tooptoop4]

https://github.com/google/go-containerregistry/blob/main/pkg/authn/k8schain/go.mod#L31

[lens0021]

If you are interested in testing this please build your own image using make workflow-controller-image.

I've tried this, built an image and deployed it. I added the following values as I am using the helm chart.

  controller:
    image:
      registry: [MY_REGISTIRY]
      repository: [REPOSITORY]
      tag: argo-workflows-3.6.2-gh-14008

After doing that, the workflows which has a private image served by AWS ECR (400721425664.dkr.ecr.ap-northeast-2.amazonaws.com/platform-service) succeed to run, though on 3.6.2.

@Joibel Is there another thing I can do to help this will be merged?

[terrytangyuan]

Thanks!

[Joibel]

/cherry-pick release-3.6

[Joibel]

I failed to backport this (it fails to automatically backport and I forgot the manual version). It's in progress and will be in the next 3.6 release, which I'll try to do sooner rather than later.

[emeier]

@Joibel thanks for this fix! we're doing some cluster migrations and this is currently blocking us, don't want to go back to 3.5 so eagerly awaiting the release.